[Refactor Xcode Objects] Enable generating per file '--help' compiler flag

tools/gn/xcode_object.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/xcode_object.h"
 
 #include <iomanip>
 #include <sstream>
 #include <utility>
 
@@ skipping 347 matching lines @@
   PrintProperty(out, rules, "buildPhases", build_phases_);
   PrintProperty(out, rules, "dependencies", EmptyPBXObjectVector());
   PrintProperty(out, rules, "name", name_);
   PrintProperty(out, rules, "productName", name_);
   out << indent_str << "};\n";
 }
 
 // PBXBuildFile ---------------------------------------------------------------
 
 PBXBuildFile::PBXBuildFile(const PBXFileReference* file_reference,
-                           const PBXSourcesBuildPhase* build_phase)
-    : file_reference_(file_reference), build_phase_(build_phase) {
+                           const PBXSourcesBuildPhase* build_phase,
+                           const HelpCompilerFlagEnabled help_flag_enabled)
+    : file_reference_(file_reference),
+      build_phase_(build_phase),
+      help_flag_enabled_(help_flag_enabled) {
   DCHECK(file_reference_);
   DCHECK(build_phase_);
 }
 
 PBXBuildFile::~PBXBuildFile() {}
 
 PBXObjectClass PBXBuildFile::Class() const {
   return PBXBuildFileClass;
 }
 
 std::string PBXBuildFile::Name() const {
   return file_reference_->Name() + " in " + build_phase_->Name();
 }
 
 void PBXBuildFile::Print(std::ostream& out, unsigned indent) const {
   const std::string indent_str(indent, '\t');
   const IndentRules rules = {true, 0};
   out << indent_str << Reference() << " = {";
   PrintProperty(out, rules, "isa", ToString(Class()));
   PrintProperty(out, rules, "fileRef", file_reference_);
+  if (help_flag_enabled_ == HelpCompilerFlagEnabled::HELP_FLAG_ENABLED) {
+    std::map<std::string, std::string> settings = {
+        {"COMPILER_FLAGS", "-h"},

[justincohen, 2016/12/14 20:00:17]

Is it -h or --help ?

[liaoyuke, 2016/12/14 20:29:23]

Thank you for catching it! I meant to type "-help". It seems that both "-help"
and "--help" would work, but I'd go with "--help" as this is the one used in
Clang documentation.

[liaoyuke, 2016/12/14 20:29:23]

Done.

+    };
+    PrintProperty(out, rules, "settings", settings);
+  }
   out << "};\n";
 }
 
 // PBXFileReference -----------------------------------------------------------
 
 PBXFileReference::PBXFileReference(const std::string& name,
                                    const std::string& path,
                                    const std::string& type)
     : name_(name), path_(path), type_(type) {}
 
@@ skipping 153 matching lines @@
   build_phases_.push_back(base::WrapUnique(new PBXSourcesBuildPhase));
   source_build_phase_ =
       static_cast<PBXSourcesBuildPhase*>(build_phases_.back().get());
 
   build_phases_.push_back(base::WrapUnique(new PBXFrameworksBuildPhase));
 }
 
 PBXNativeTarget::~PBXNativeTarget() {}
 
 void PBXNativeTarget::AddFileForIndexing(
-    const PBXFileReference* file_reference) {
+    const PBXFileReference* file_reference,
+    const PBXBuildFile::HelpCompilerFlagEnabled help_flag_enabled) {
   DCHECK(file_reference);
-  source_build_phase_->AddBuildFile(
-      base::MakeUnique<PBXBuildFile>(file_reference, source_build_phase_));
+  source_build_phase_->AddBuildFile(base::MakeUnique<PBXBuildFile>(
+      file_reference, source_build_phase_, help_flag_enabled));
 }
 
 PBXObjectClass PBXNativeTarget::Class() const {
   return PBXNativeTargetClass;
 }
 
 void PBXNativeTarget::Print(std::ostream& out, unsigned indent) const {
   const std::string indent_str(indent, '\t');
   const IndentRules rules = {false, indent + 1};
   out << indent_str << Reference() << " = {\n";
@@ skipping 23 matching lines @@
       main_group_->AddChild(base::MakeUnique<PBXGroup>(source_path, "Source")));
   products_ = static_cast<PBXGroup*>(main_group_->AddChild(
       base::MakeUnique<PBXGroup>(std::string(), "Product")));
   main_group_->AddChild(base::MakeUnique<PBXGroup>(std::string(), "Build"));
 
   configurations_.reset(new XCConfigurationList(config_name, attributes, this));
 }
 
 PBXProject::~PBXProject() {}
 
-void PBXProject::AddSourceFile(const std::string& source_path) {
+void PBXProject::AddSourceFile(
+    const std::string& source_path,
+    const PBXBuildFile::HelpCompilerFlagEnabled help_flag_enabled) {
   PBXFileReference* file_reference = sources_->AddSourceFile(source_path);
   base::StringPiece ext = FindExtension(&source_path);
   if (!IsSourceFileForIndexing(ext))
     return;
 
   if (!target_for_indexing_) {
     PBXAttributes attributes;
     attributes["EXECUTABLE_PREFIX"] = "";
     attributes["HEADER_SEARCH_PATHS"] = sources_->path();
     attributes["PRODUCT_NAME"] = name_;
 
     PBXFileReference* product_reference = static_cast<PBXFileReference*>(
         products_->AddChild(base::MakeUnique<PBXFileReference>(
             std::string(), name_, "compiled.mach-o.executable")));
 
     const char product_type[] = "com.apple.product-type.tool";
     targets_.push_back(base::MakeUnique<PBXNativeTarget>(
         name_, std::string(), config_name_, attributes, product_type, name_,
         product_reference));
     target_for_indexing_ = static_cast<PBXNativeTarget*>(targets_.back().get());
   }
 
   DCHECK(target_for_indexing_);
-  target_for_indexing_->AddFileForIndexing(file_reference);
+  target_for_indexing_->AddFileForIndexing(file_reference, help_flag_enabled);
 }
 
 void PBXProject::AddAggregateTarget(const std::string& name,
                                     const std::string& shell_script) {
   PBXAttributes attributes;
   attributes["CODE_SIGNING_REQUIRED"] = "NO";
   attributes["CONFIGURATION_BUILD_DIR"] = ".";
   attributes["PRODUCT_NAME"] = name;
 
   targets_.push_back(base::MakeUnique<PBXAggregateTarget>(
@@ skipping 214 matching lines @@
   const std::string indent_str(indent, '\t');
   const IndentRules rules = {false, indent + 1};
   out << indent_str << Reference() << " = {\n";
   PrintProperty(out, rules, "isa", ToString(Class()));
   PrintProperty(out, rules, "buildConfigurations", configurations_);
   PrintProperty(out, rules, "defaultConfigurationIsVisible", 1u);
   PrintProperty(out, rules, "defaultConfigurationName",
                 configurations_[0]->Name());
   out << indent_str << "};\n";
 }