Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl

Issue 2574303002: Fix low risk non-nullable => nullable attributes / arguments to match the spec (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl
diff --git a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl
index 16692881571c9f0cb4044a5b2153c109f8e0c382..b0941ae667c5551e9d05e4dc993ad47f9920f4e6 100644
--- a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl
+++ b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl
@@ -16,7 +16,7 @@
readonly attribute MediaStreamTrack videoStreamTrack;
[CallWith=ScriptState, RaisesException] Promise<PhotoCapabilities> getPhotoCapabilities();
- [CallWith=ScriptState, RaisesException] Promise<void> setOptions(PhotoSettings photoSettings);
+ [CallWith=ScriptState, RaisesException] Promise<void> setOptions(PhotoSettings? photoSettings);
foolip 2016/12/14 19:17:12 The spec needs to change here, a nullable dictiona
foolip 2016/12/14 19:18:02 Actually, leave the spec link for another CL when
lunalu1 2016/12/15 11:33:59 I will reverse the change because the change will
[CallWith=ScriptState, RaisesException] Promise<Blob> takePhoto();
[CallWith=ScriptState, RaisesException] Promise<ImageBitmap> grabFrame();
};

Powered by Google App Engine
This is Rietveld 408576698