Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2574293003: [SPInvalidation] Update paint properties when layer or paintsWithTransform status change (Closed)
Patch Set: Rebase on origin/master Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 17369a27025b82ed5aa032f5c45b5cd8f8cb0724..3271981ad0d0d28a9d695e1f70b0a6fd5115d775 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -298,6 +298,20 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff,
}
}
+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
+ // hasLayer status will affect whether to create localBorderBoxProperties.
+ if (hadLayer != hasLayer()) {
+ setNeedsPaintPropertyUpdate();
+ } else if (oldStyle && oldStyle->position() != styleRef().position() &&
+ (oldStyle->position() == FixedPosition ||
+ styleRef().position() == FixedPosition)) {
+ // Fixed-position status affects whether to create paintOffsetTranslation.
+ // TODO(chrishtr): Update the condition here when changing the condition
+ // in PaintPropertyTreeBuilder::updatePaintOffsetTranslation().
+ setNeedsPaintPropertyUpdate();
+ }
+ }
+
if (layer()) {
layer()->styleDidChange(diff, oldStyle);
if (hadLayer && layer()->isSelfPaintingLayer() != layerWasSelfPainting)
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698