Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2574293003: [SPInvalidation] Update paint properties when layer or paintsWithTransform status change (Closed)
Patch Set: Also fix paintOffsetTranslation Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 setChildNeedsLayout(); 291 setChildNeedsLayout();
292 if (hadTransform) 292 if (hadTransform)
293 setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( 293 setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(
294 LayoutInvalidationReason::StyleChange); 294 LayoutInvalidationReason::StyleChange);
295 if (!needsLayout()) { 295 if (!needsLayout()) {
296 // FIXME: We should call a specialized version of this function. 296 // FIXME: We should call a specialized version of this function.
297 parentLayer->updateLayerPositionsAfterLayout(); 297 parentLayer->updateLayerPositionsAfterLayout();
298 } 298 }
299 } 299 }
300 300
301 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
302 // hasLayer status will affect whether to create localBorderBoxProperties.
303 if (hadLayer != hasLayer()) {
304 setNeedsPaintPropertyUpdate();
305 } else {
306 bool hasPaintOffsetTranslation =
307 paintProperties() && paintProperties()->paintOffsetTranslation();
308 bool willHavePaintOffsetTranslation =
309 hasLayer() &&
310 layer()->paintsWithTransform(GlobalPaintFlattenCompositingLayers);
311 if (hasPaintOffsetTranslation != willHavePaintOffsetTranslation)
312 setNeedsPaintPropertyUpdate();
313 }
314 }
315
301 if (layer()) { 316 if (layer()) {
302 layer()->styleDidChange(diff, oldStyle); 317 layer()->styleDidChange(diff, oldStyle);
303 if (hadLayer && layer()->isSelfPaintingLayer() != layerWasSelfPainting) 318 if (hadLayer && layer()->isSelfPaintingLayer() != layerWasSelfPainting)
304 setChildNeedsLayout(); 319 setChildNeedsLayout();
305 } 320 }
306 321
307 if (oldStyle && wasHorizontalWritingMode != isHorizontalWritingMode()) { 322 if (oldStyle && wasHorizontalWritingMode != isHorizontalWritingMode()) {
308 // Changing the getWritingMode() may change isOrthogonalWritingModeRoot() 323 // Changing the getWritingMode() may change isOrthogonalWritingModeRoot()
309 // of children. Make sure all children are marked/unmarked as orthogonal 324 // of children. Make sure all children are marked/unmarked as orthogonal
310 // writing-mode roots. 325 // writing-mode roots.
(...skipping 1005 matching lines...) Expand 10 before | Expand all | Expand 10 after
1316 if (rootElementStyle->hasBackground()) 1331 if (rootElementStyle->hasBackground())
1317 return false; 1332 return false;
1318 1333
1319 if (node() != document().firstBodyElement()) 1334 if (node() != document().firstBodyElement())
1320 return false; 1335 return false;
1321 1336
1322 return true; 1337 return true;
1323 } 1338 }
1324 1339
1325 } // namespace blink 1340 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698