Issue 257423009: Convert function.length to API-style accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257423009: Convert function.length to API-style accessor. (Closed)

Created:
6 years, 8 months ago by ulan

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Convert function.length to API-style accessor. TEST=mjsunit/function-length-accessor R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20937

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -25 lines)			Patch
M	src/accessors.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/accessors.cc	View	1 chunk	+46 lines, -20 lines	1 comment	Download
M	src/bootstrapper.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download
A	test/mjsunit/function-length-accessor.js	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

PTAL https://codereview.chromium.org/257423009/diff/1/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/257423009/diff/1/src/accessors.cc#newcode918 src/accessors.cc:918: isolate->OptionalRescheduleException(false); I added a test that checks this.

6 years, 8 months ago (2014-04-24 10:27:03 UTC) #1

Yang

On 2014/04/24 10:27:03, ulan wrote: > PTAL > > https://codereview.chromium.org/257423009/diff/1/src/accessors.cc > File src/accessors.cc (right): > ...

6 years, 8 months ago (2014-04-24 10:56:49 UTC) #2

ulan

6 years, 8 months ago (2014-04-24 11:24:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20937 (presubmit successful).

Expand Messages | Collapse Messages