Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/pkg/angular/lib/core/parser/unparser.dart

Issue 257423008: Update all Angular libs (run update_all.sh). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/pkg/angular/lib/core/parser/unparser.dart
diff --git a/third_party/pkg/angular/lib/core/parser/unparser.dart b/third_party/pkg/angular/lib/core/parser/unparser.dart
index cbf968f2d83adf0bc3b7aa49962b7404e68be562..906e4b9124c08819359d58dcdb1d398b462c869f 100644
--- a/third_party/pkg/angular/lib/core/parser/unparser.dart
+++ b/third_party/pkg/angular/lib/core/parser/unparser.dart
@@ -13,27 +13,35 @@ class Unparser extends Visitor {
return "$buffer";
}
- write(String string) {
+ void write(String string) {
buffer.write(string);
}
- writeArguments(List<Expression> arguments) {
+ void writeArguments(CallArguments arguments) {
+ bool first = true;
write('(');
- for (int i = 0; i < arguments.length; i++) {
- if (i != 0) write(',');
- visit(arguments[i]);
+ for (int i = 0; i < arguments.positionals.length; i++) {
+ if (!first) write(', ');
+ first = false;
+ visit(arguments.positionals[i]);
}
+ arguments.named.forEach((String name, value) {
+ if (!first) write(', ');
+ first = false;
+ write('$name: ');
+ visit(value);
+ });
write(')');
}
- visitChain(Chain chain) {
+ void visitChain(Chain chain) {
for (int i = 0; i < chain.expressions.length; i++) {
if (i != 0) write(';');
visit(chain.expressions[i]);
}
}
- visitFilter(Filter filter) {
+ void visitFilter(Filter filter) {
write('(');
visit(filter.expression);
write('|${filter.name}');
@@ -44,13 +52,13 @@ class Unparser extends Visitor {
write(')');
}
- visitAssign(Assign assign) {
+ void visitAssign(Assign assign) {
visit(assign.target);
write('=');
visit(assign.value);
}
- visitConditional(Conditional conditional) {
+ void visitConditional(Conditional conditional) {
visit(conditional.condition);
write('?');
visit(conditional.yes);
@@ -58,45 +66,47 @@ class Unparser extends Visitor {
visit(conditional.no);
}
- visitAccessScope(AccessScope access) {
+ void visitAccessScope(AccessScope access) {
write(access.name);
}
- visitAccessMember(AccessMember access) {
+ void visitAccessMember(AccessMember access) {
visit(access.object);
write('.${access.name}');
}
- visitAccessKeyed(AccessKeyed access) {
+ void visitAccessKeyed(AccessKeyed access) {
visit(access.object);
write('[');
visit(access.key);
write(']');
}
- visitCallScope(CallScope call) {
+ void visitCallScope(CallScope call) {
write(call.name);
writeArguments(call.arguments);
}
- visitCallFunction(CallFunction call) {
+ void visitCallFunction(CallFunction call) {
+ write('(');
visit(call.function);
+ write(')');
writeArguments(call.arguments);
}
- visitCallMember(CallMember call) {
+ void visitCallMember(CallMember call) {
visit(call.object);
write('.${call.name}');
writeArguments(call.arguments);
}
- visitPrefix(Prefix prefix) {
+ void visitPrefix(Prefix prefix) {
write('(${prefix.operation}');
visit(prefix.expression);
write(')');
}
- visitBinary(Binary binary) {
+ void visitBinary(Binary binary) {
write('(');
visit(binary.left);
write(binary.operation);
@@ -104,11 +114,11 @@ class Unparser extends Visitor {
write(')');
}
- visitLiteralPrimitive(LiteralPrimitive literal) {
+ void visitLiteralPrimitive(LiteralPrimitive literal) {
write("${literal.value}");
}
- visitLiteralArray(LiteralArray literal) {
+ void visitLiteralArray(LiteralArray literal) {
write('[');
for (int i = 0; i < literal.elements.length; i++) {
if (i != 0) write(',');
@@ -117,7 +127,7 @@ class Unparser extends Visitor {
write(']');
}
- visitLiteralObject(LiteralObject literal) {
+ void visitLiteralObject(LiteralObject literal) {
write('{');
List<String> keys = literal.keys;
for (int i = 0; i < keys.length; i++) {
@@ -128,7 +138,7 @@ class Unparser extends Visitor {
write('}');
}
- visitLiteralString(LiteralString literal) {
+ void visitLiteralString(LiteralString literal) {
String escaped = literal.value.replaceAll("'", "\\'");
write("'$escaped'");
}
« no previous file with comments | « third_party/pkg/angular/lib/core/parser/tokens.dart ('k') | third_party/pkg/angular/lib/core/parser/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698