Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2574193003: Support generic methods in kernel (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -17 lines) Patch
M pkg/compiler/lib/src/kernel/kernel.dart View 3 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 4 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years ago (2016-12-14 13:52:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-15 19:17:57 UTC) #3
Johnni Winther
4 years ago (2016-12-16 08:42:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
16053d31f6cb0e7fe67132fb5f7259ba164c2a42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698