Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: content/browser/loader/async_resource_handler_browsertest.cc

Issue 2574143003: Implement upload progress handling in Mojo loading (Closed)
Patch Set: +comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/DEPS ('k') | content/browser/loader/mojo_async_resource_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/async_resource_handler_browsertest.cc
diff --git a/content/browser/loader/async_resource_handler_browsertest.cc b/content/browser/loader/async_resource_handler_browsertest.cc
index e1bc8fe68abf3feb1a2a14e9ea8e83b009f18739..36b90ed76df7bf2eecd53cd321cf9821e0924bc0 100644
--- a/content/browser/loader/async_resource_handler_browsertest.cc
+++ b/content/browser/loader/async_resource_handler_browsertest.cc
@@ -8,6 +8,7 @@
#include <string>
#include <utility>
+#include "base/command_line.h"
#include "base/format_macros.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -64,10 +65,18 @@ std::unique_ptr<net::test_server::HttpResponse> HandlePostAndRedirectURLs(
} // namespace
-class AsyncResourceHandlerBrowserTest : public ContentBrowserTest {
+class AsyncResourceHandlerBrowserTest
+ : public ContentBrowserTest,
+ public testing::WithParamInterface<bool> {
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ if (GetParam()) {
+ command_line->AppendSwitchASCII("--enable-blink-features",
+ "LoadingWithMojo");
+ }
+ }
};
-IN_PROC_BROWSER_TEST_F(AsyncResourceHandlerBrowserTest, UploadProgress) {
+IN_PROC_BROWSER_TEST_P(AsyncResourceHandlerBrowserTest, UploadProgress) {
net::EmbeddedTestServer* test_server = embedded_test_server();
test_server->RegisterRequestHandler(
base::Bind(&HandlePostAndRedirectURLs, kPostPath));
@@ -84,7 +93,7 @@ IN_PROC_BROWSER_TEST_F(AsyncResourceHandlerBrowserTest, UploadProgress) {
EXPECT_EQ(js_result, "success");
}
-IN_PROC_BROWSER_TEST_F(AsyncResourceHandlerBrowserTest,
+IN_PROC_BROWSER_TEST_P(AsyncResourceHandlerBrowserTest,
UploadProgressRedirect) {
net::EmbeddedTestServer* test_server = embedded_test_server();
test_server->RegisterRequestHandler(
@@ -102,4 +111,8 @@ IN_PROC_BROWSER_TEST_F(AsyncResourceHandlerBrowserTest,
EXPECT_EQ(js_result, "success");
}
+INSTANTIATE_TEST_CASE_P(AsyncResourceHandlerBrowserTest,
+ AsyncResourceHandlerBrowserTest,
+ ::testing::Values(false, true));
+
} // namespace content
« no previous file with comments | « content/browser/loader/DEPS ('k') | content/browser/loader/mojo_async_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698