Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: runtime/vm/object.cc

Issue 257413002: - Remove some unnecessary classes from the object store. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 35325)
+++ runtime/vm/object.cc (working copy)
@@ -1018,7 +1018,6 @@
// Super type set below, after Object is allocated.
cls = Class::New<JSRegExp>();
- object_store->set_jsregexp_class(cls);
RegisterPrivateClass(cls, Symbols::JSSyntaxRegExp(), core_lib);
pending_classes.Add(cls);
@@ -1129,7 +1128,6 @@
ASSERT(lib.raw() == Library::MirrorsLibrary());
cls = Class::New<MirrorReference>();
- object_store->set_mirror_reference_class(cls);
RegisterPrivateClass(cls, Symbols::_MirrorReference(), lib);
// Pre-register the profiler library so we can place the vm class
@@ -1147,7 +1145,6 @@
lib = Library::LookupLibrary(Symbols::DartProfiler());
ASSERT(!lib.IsNull());
cls = Class::New<UserTag>();
- object_store->set_user_tag_class(cls);
RegisterPrivateClass(cls, Symbols::_UserTag(), lib);
pending_classes.Add(cls);
@@ -1441,7 +1438,6 @@
object_store->set_stacktrace_class(cls);
cls = Class::New<JSRegExp>();
- object_store->set_jsregexp_class(cls);
// Some classes are not stored in the object store. Yet we still need to
// create their Class object so that they get put into the class_table
@@ -1452,10 +1448,8 @@
object_store->set_weak_property_class(cls);
cls = Class::New<MirrorReference>();
- object_store->set_mirror_reference_class(cls);
cls = Class::New<UserTag>();
- object_store->set_user_tag_class(cls);
}
@@ -18238,8 +18232,6 @@
RawJSRegExp* JSRegExp::New(intptr_t len, Heap::Space space) {
- ASSERT(Isolate::Current()->object_store()->jsregexp_class() !=
- Class::null());
if (len < 0 || len > kMaxElements) {
// This should be caught before we reach here.
FATAL1("Fatal error in JSRegexp::New: invalid len %" Pd "\n", len);
@@ -18387,8 +18379,6 @@
RawMirrorReference* MirrorReference::New(const Object& referent,
Heap::Space space) {
- ASSERT(Isolate::Current()->object_store()->mirror_reference_class()
- != Class::null());
MirrorReference& result = MirrorReference::Handle();
{
RawObject* raw = Object::Allocate(MirrorReference::kClassId,
@@ -18428,7 +18418,6 @@
RawUserTag* UserTag::New(const String& label, Heap::Space space) {
Isolate* isolate = Isolate::Current();
- ASSERT(isolate->object_store()->user_tag_class() != Class::null());
ASSERT(isolate->tag_table() != GrowableObjectArray::null());
// Canonicalize by name.
UserTag& result = UserTag::Handle(FindTagInIsolate(isolate, label));
« no previous file with comments | « no previous file | runtime/vm/object_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698