Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 257403002: Oilpan: Revert r169564: Disable the GC_PLUGIN_IGNORE annotation when compiling with asan. (Closed)

Created:
6 years, 7 months ago by zerny-chromium
Modified:
6 years, 7 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), oilpan-reviews
Visibility:
Public.

Description

Oilpan: Revert r169564: Disable the GC_PLUGIN_IGNORE annotation when compiling with asan. A fixed clang/asan has been rolled. See https://code.google.com/p/address-sanitizer/issues/detail?id=279 R=ager@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/Heap.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
zerny-chromium
6 years, 7 months ago (2014-04-30 10:33:52 UTC) #1
Mads Ager (chromium)
LGTM!
6 years, 7 months ago (2014-04-30 10:35:34 UTC) #2
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-04-30 10:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/257403002/1
6 years, 7 months ago (2014-04-30 10:38:15 UTC) #4
haraken
LGTM
6 years, 7 months ago (2014-04-30 11:21:42 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 11:45:24 UTC) #6
Message was sent while issue was closed.
Change committed as 172972

Powered by Google App Engine
This is Rietveld 408576698