Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3471)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 2574003002: Android: Remove MobileStartup.Toolbar* histograms (Closed)
Patch Set: Remove one more. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
index e3a54955f8267a339ec9bde8d7617dfa2df02858..5b96836030b426596316b5061e0e401c680caef5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
@@ -10,7 +10,6 @@ import android.graphics.drawable.Drawable;
import android.os.Handler;
import android.os.Looper;
import android.os.Message;
-import android.os.SystemClock;
import android.support.v7.app.ActionBar;
import android.text.TextUtils;
import android.view.View;
@@ -19,8 +18,6 @@ import android.view.View.OnClickListener;
import android.widget.FrameLayout;
import org.chromium.base.ApiCompatibilityUtils;
-import org.chromium.base.ThreadUtils;
-import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity;
@@ -77,7 +74,6 @@ import org.chromium.ui.base.PageTransition;
import java.util.ArrayList;
import java.util.List;
-import java.util.concurrent.TimeUnit;
/**
* Contains logic for managing the toolbar visual component. This class manages the interactions
@@ -988,35 +984,6 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
}
/**
- * Handle all necessary tasks that can be delayed until initialization completes.
- * @param activityCreationTimeMs The time of creation for the activity this toolbar belongs to.
- * @param activityName Simple class name for the activity this toolbar belongs to.
- */
- public void onDeferredStartup(final long activityCreationTimeMs,
- final String activityName) {
- // Record startup performance statistics
- long elapsedTime = SystemClock.elapsedRealtime() - activityCreationTimeMs;
- if (elapsedTime < RECORD_UMA_PERFORMANCE_METRICS_DELAY_MS) {
- ThreadUtils.postOnUiThreadDelayed(new Runnable() {
- @Override
- public void run() {
- onDeferredStartup(activityCreationTimeMs, activityName);
- }
- }, RECORD_UMA_PERFORMANCE_METRICS_DELAY_MS - elapsedTime);
- }
- RecordHistogram.recordTimesHistogram("MobileStartup.ToolbarFirstDrawTime." + activityName,
- mToolbar.getFirstDrawTime() - activityCreationTimeMs, TimeUnit.MILLISECONDS);
-
- long firstFocusTime = mToolbar.getLocationBar().getFirstUrlBarFocusTime();
- if (firstFocusTime != 0) {
- RecordHistogram.recordCustomTimesHistogram(
- "MobileStartup.ToolbarFirstFocusTime." + activityName,
- firstFocusTime - activityCreationTimeMs, MIN_FOCUS_TIME_FOR_UMA_HISTOGRAM_MS,
- MAX_FOCUS_TIME_FOR_UMA_HISTOGRAM_MS, TimeUnit.MILLISECONDS, 50);
- }
- }
-
- /**
* Finish any toolbar animations.
*/
public void finishAnimations() {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698