Issue 25740005: Observe keyboard notifications in docked layout

Issue 25740005: Observe keyboard notifications in docked layout (Closed)

Created:
7 years, 2 months ago by varkha

Modified:
7 years, 2 months ago

Reviewers:
oshima, bshe

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	ash/root_window_controller.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ash/wm/dock/docked_window_layout_manager.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

bshe

On 2013/10/03 01:47:09, varkha wrote: > bshe@, could you please take a first look? lgtm

7 years, 2 months ago (2013-10-03 17:47:17 UTC) #2

varkha

oshima@, please take a look. Calling AddObserver(docked_layout) on the keyboard controller was missed in the ...

7 years, 2 months ago (2013-10-03 18:17:07 UTC) #3

oshima

On 2013/10/03 18:17:07, varkha wrote: > oshima@, please take a look. Calling AddObserver(docked_layout) on the ...

7 years, 2 months ago (2013-10-03 18:32:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/25740005/1

7 years, 2 months ago (2013-10-03 18:40:24 UTC) #5

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 2 months ago (2013-10-03 18:51:12 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/25740005/1

7 years, 2 months ago (2013-10-03 18:58:56 UTC) #7

Message was sent while issue was closed.

Change committed as 226874