Issue 257393003: Revert of Multiprofile: switch to newly added user to the session

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257393003: Revert of Multiprofile: switch to newly added user to the session (Closed)

Created:
6 years, 7 months ago by Nikita (slow)

Modified:
6 years, 7 months ago

Reviewers:
Dmitry Polukhin, dpolukhin

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Multiprofile: switch to newly added user to the session (https://codereview.chromium.org/246253009/) Reason for revert: Suspecting this change as a root cause for superflaky UserAddingScreenTest.AddingSeveralUsers See http://crbug.com/368621 Original issue's description: > Multiprofile: switch to newly added user to the session > > This CL remember pending user switch and do it as soon as profile > ready. From UI perspective this look very smooth because profile loading > is actually fast so previous desktop is not shown. But if it will be > a problem on slow device we may need to stay on add user screen a bit longer. > > BUG=333879 > TEST=manual > R=nkostylev@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266239 TBR=dpolukhin@chromium.org,dpolukhin@google.com NOTREECHECKS=true NOTRY=true BUG=333879, 368621 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267174

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -22 lines)			Patch
M	chrome/browser/chromeos/file_manager/file_manager_browsertest.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View	2 chunks	+3 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/preferences_browsertest.cc	View	1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

Nikita (slow)

Created Revert of Multiprofile: switch to newly added user to the session

6 years, 7 months ago (2014-04-30 10:58:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/257393003/1

6 years, 7 months ago (2014-04-30 10:59:27 UTC) #3

Message was sent while issue was closed.

Change committed as 267174