Add devil dependencies config for performance tests.

tools/perf/chrome_telemetry_build/chromium_config.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import sys
 
 
 def GetChromiumSrcDir():
   return os.path.abspath(
       os.path.join(os.path.abspath(__file__), '..', '..', '..', '..'))
 
 
 def GetTelemetryDir():
   return os.path.join(GetChromiumSrcDir(), 'third_party', 'catapult',
                       'telemetry')
 
+def GetDevilDir():
+  return os.path.join(GetChromiumSrcDir(), 'third_party', 'catapult',
+                      'devil')
 
 CLIENT_CONFIG_PATH = os.path.join(
     os.path.dirname(os.path.abspath(__file__)), 'binary_dependencies.json')
+DEVIL_CONFIG_PATH = os.path.join(
+    os.path.dirname(os.path.abspath(__file__)), 'devil_dependencies.json')
 
 sys.path.insert(1, os.path.join(GetTelemetryDir()))
+sys.path.insert(1, os.path.join(GetDevilDir()))
 
 from telemetry import project_config
+from devil import devil_env
 
 
 class ChromiumConfig(project_config.ProjectConfig):
 
   def __init__(self, top_level_dir=None, benchmark_dirs=None,
                client_configs=None,
                default_chrome_root=GetChromiumSrcDir()):
     if client_configs is None:
       client_configs = [CLIENT_CONFIG_PATH]
 
     perf_dir = os.path.join(GetChromiumSrcDir(), 'tools', 'perf')
     if not benchmark_dirs:
       benchmark_dirs = [os.path.join(perf_dir, 'benchmarks')]
       logging.info('No benchmark directories specified. Defaulting to %s',
                    benchmark_dirs)
     if not top_level_dir:
       top_level_dir = perf_dir
       logging.info('No top level directory specified. Defaulting to %s',
                    top_level_dir)
 
     super(ChromiumConfig, self).__init__(
         top_level_dir=top_level_dir, benchmark_dirs=benchmark_dirs,
         client_configs=client_configs, default_chrome_root=default_chrome_root)
+
+    devil_env.config.Initialize(config_files=[DEVIL_CONFIG_PATH])

[jbudorick, 2016/12/16 18:32:57]

The right way to handle this would be to call
devil_chromium.Initialize(output_directory=...), but to do that, we'd need to
get the chromium output directory down here.

[aiolos (Not reviewing), 2016/12/16 18:39:22]

This should instead be done in telemetry's binary manager, which knows about the
Chromium src dir (and therefore the output dir) if we're in a Chromium checkout.

[djordje.golubovic, 2016/12/20 15:16:03]

Thanks for your inputs.

I just need a bit of clarification - does this mean
devil_chromium.Initialize(output_directory=...) should be called from
binary_manager in third_party/catapult? If so, devil_chromium module must (as
far as I know) be imported from Chromium src dir (another checkout), which
sounds suspicious to me.

Or, devil_chromium.Initialize(...) could be called here (same checkout), and use
telemetry.core.util.GetBuildDirectories() to get Chromium out dir (this module
already knows where telemetry is).

[jbudorick, 2016/12/20 16:55:44]

It seems that they're not entirely compatible, unfortunately. :(
I'll defer to aiolos for what the best course of action is, although my
relatively uninformed guess would that it'd be the latter option.

[djordje.golubovic, 2016/12/21 17:58:55]

Done.

[djordje.golubovic, 2016/12/21 17:58:55]

Done.