Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 25739004: PNaCl documentation: explain how PNaCl can build with a different C++ standard library, and how to … (Closed)

Created:
7 years, 2 months ago by JF
Modified:
7 years, 2 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

PNaCl documentation: explain how PNaCl can build with a different C++ standard library, and how to use C++11 R= eliben@chromium.org, dschuff@chromium.org, mackinlay@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3634 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226537

Patch Set 1 #

Total comments: 2

Patch Set 2 : Indicate that libc++ support is preliminary. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
JF
7 years, 2 months ago (2013-10-02 18:01:27 UTC) #1
eliben
lgtm
7 years, 2 months ago (2013-10-02 18:03:09 UTC) #2
Derek Schuff
https://codereview.chromium.org/25739004/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/25739004/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode84 native_client_sdk/src/doc/devguide/devcycle/building.rst:84: indicate which C++ language standard to use. we should ...
7 years, 2 months ago (2013-10-02 18:10:15 UTC) #3
JF
https://codereview.chromium.org/25739004/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/25739004/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode84 native_client_sdk/src/doc/devguide/devcycle/building.rst:84: indicate which C++ language standard to use. On 2013/10/02 ...
7 years, 2 months ago (2013-10-02 18:15:46 UTC) #4
Derek Schuff
lgtm
7 years, 2 months ago (2013-10-02 18:30:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/25739004/7001
7 years, 2 months ago (2013-10-02 19:43:12 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 19:53:11 UTC) #7
Message was sent while issue was closed.
Change committed as 226537

Powered by Google App Engine
This is Rietveld 408576698