third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)

Patch Set: address feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index 72f565e888b8af90e14ccdae7aa7efba0629057f..0bd2249f7757837cd8d817c4ccc4bf2a8d07372c 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -155,7 +155,8 @@ class WEB_EXPORT ChromeClientImpl final : public ChromeClient {

void enterFullscreen(LocalFrame&) override;

void exitFullscreen(LocalFrame&) override;

- void fullscreenElementChanged(Element*, Element*) override;

+ void fullscreenElementChanged(Element* fromElement,

+ Element* toElement) override;

void clearCompositedSelection(LocalFrame*) override;

void updateCompositedSelection(LocalFrame*,