third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp - Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp

Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)

Patch Set: address feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp

index 11b878bfb59e0588b298ff473dbd5005b492a8af..e0ccfd71cbf7a66354d7ac2b426b81fe3b84892c 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp

@@ -170,13 +170,13 @@ class MediaControlsOrientationLockDelegateTest : public ::testing::Test {

Fullscreen::requestFullscreen(video());

Fullscreen::from(document()).didEnterFullscreen();

- testing::runPendingTasks();

+ document().serviceScriptedAnimations(WTF::monotonicallyIncreasingTime());

}

void simulateExitFullscreen() {

Fullscreen::exitFullscreen(document());

Fullscreen::from(document()).didExitFullscreen();

- testing::runPendingTasks();

+ document().serviceScriptedAnimations(WTF::monotonicallyIncreasingTime());

}

void simulateOrientationLock() {

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »