third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp - Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)

Patch Set: address feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

index 77046c3b2ad24a774e8c5737e3b599527bf9ec82..5b16dac3709afd48dda33df3729aec1da488fc18 100644

--- a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

@@ -143,7 +143,7 @@ void LayoutTreeBuilderForElement::createLayoutObject() {

newLayoutObject->setStyle(

&style); // setStyle() can depend on layoutObject() already being set.

- if (Fullscreen::isCurrentFullScreenElement(*m_node)) {

+ if (Fullscreen::isFullscreenElement(*m_node)) {

newLayoutObject = LayoutFullScreen::wrapLayoutObject(

newLayoutObject, parentLayoutObject, &m_node->document());

if (!newLayoutObject)