third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-vs-exit.html - Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-vs-exit.html

Issue 2573773002: Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)

Patch Set: address feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-two-iframes.html ('k') | third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Element#requestFullscreen() vs. Document#exitFullscreen()</title>	2 <title>Element#requestFullscreen() vs. Document#exitFullscreen()</title>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script src="../trusted-click.js"></script>	5 <script src="../trusted-click.js"></script>

6 <div id="log"></div>	6 <div id="log"></div>

7 <div id="target"></div>	7 <div id="target"></div>

8 <script>	8 <script>

9 // Adapted from https://github.com/w3c/web-platform-tests/pull/4250	9 // Adapted from https://github.com/w3c/web-platform-tests/pull/4250

10 // TODO(foolip): Remove this test when the above is imported and passing.	10 // TODO(foolip): Remove this test when the above is imported and passing.

11 async_test(t => {	11 async_test(t => {

12 const target = document.getElementById("target");	12 const target = document.getElementById("target");

13	13

14 trusted_click(t.step_func(() => {	14 trusted_click(t.step_func(() => {

15 // Request fullscreen and exit at the same time. The exitFullscreen call	15 // Request fullscreen and exit at the same time. The exitFullscreen call

16 // should have no effect as the fullscreen element is null.	16 // should have no effect as the fullscreen element is null.

17 document.onfullscreenchange = t.step_func_done();	17 document.onfullscreenchange = t.step_func_done();

18 document.onfullscreenerror = t.unreached_func("fullscreenerror event");	18 document.onfullscreenerror = t.unreached_func("fullscreenerror event");

19	19

20 target.requestFullscreen();	20 target.requestFullscreen();

21 assert_equals(document.fullscreenElement, target, "fullscreenElement after r equestFullscreen()");	21 assert_equals(document.fullscreenElement, null, "fullscreenElement after req uestFullscreen()");

22 document.exitFullscreen();	22 document.exitFullscreen();

23 assert_equals(document.fullscreenElement, null, "fullscreenElement after exi tFullscreen()");	23 assert_equals(document.fullscreenElement, null, "fullscreenElement after exi tFullscreen()");

24 }), document.body);	24 }), document.body);

25 });	25 });

26 </script>	26 </script>

OLD	NEW