Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2573713002: [Bindings][Refactoring] Remove filters for origin trial features (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% filter format_blink_cpp_source_code %} 1 {% filter format_blink_cpp_source_code %}
2 2
3 {% include 'copyright_block.txt' %} 3 {% include 'copyright_block.txt' %}
4 #include "{{v8_class_or_partial}}.h" 4 #include "{{v8_class_or_partial}}.h"
5 5
6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %} 6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 {% endif %} 524 {% endif %}
525 } 525 }
526 526
527 {% endif %}{# not is_array_buffer_or_view #} 527 {% endif %}{# not is_array_buffer_or_view #}
528 {% endblock %} 528 {% endblock %}
529 {##############################################################################} 529 {##############################################################################}
530 {% block origin_trials %} 530 {% block origin_trials %}
531 {% from 'attributes.cpp.tmpl' import attribute_configuration with context %} 531 {% from 'attributes.cpp.tmpl' import attribute_configuration with context %}
532 {% from 'constants.cpp.tmpl' import constant_configuration with context %} 532 {% from 'constants.cpp.tmpl' import constant_configuration with context %}
533 {% from 'methods.cpp.tmpl' import method_configuration with context %} 533 {% from 'methods.cpp.tmpl' import method_configuration with context %}
534 {% for origin_trial_feature in origin_trial_features %} 534 {% for feature in origin_trial_features %}
535 void {{v8_class_or_partial}}::install{{origin_trial_feature.name}}(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::Object> instance, v8::Local <v8::Object> prototype, v8::Local<v8::Function> interface) { 535 void {{v8_class_or_partial}}::install{{feature.name}}(v8::Isolate* isolate, cons t DOMWrapperWorld& world, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface) {
536 {% if attributes | for_origin_trial_feature(origin_trial_feature.name) or 536 {% if feature.attributes or feature.methods %}
537 methods | method_for_origin_trial_feature(origin_trial_feature.name, is_ partial) %}
538 v8::Local<v8::FunctionTemplate> interfaceTemplate = {{v8_class}}::wrapperTypeI nfo.domTemplate(isolate, world); 537 v8::Local<v8::FunctionTemplate> interfaceTemplate = {{v8_class}}::wrapperTypeI nfo.domTemplate(isolate, world);
539 v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemp late); 538 v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemp late);
540 ALLOW_UNUSED_LOCAL(signature); 539 ALLOW_UNUSED_LOCAL(signature);
541 {% endif %} 540 {% endif %}
542 {# Origin-Trial-enabled attributes #} 541 {# Origin-Trial-enabled attributes #}
543 {% for attribute in attributes | for_origin_trial_feature(origin_trial_feature .name) | unique_by('name') | sort %} 542 {% for attribute in feature.attributes %}
544 {% if attribute.is_data_type_property %} 543 {% if attribute.is_data_type_property %}
545 const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Co nfiguration = {{attribute_configuration(attribute)}}; 544 const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Co nfiguration = {{attribute_configuration(attribute)}};
546 V8DOMConfiguration::installAttribute(isolate, world, instance, prototype, attr ibute{{attribute.name}}Configuration); 545 V8DOMConfiguration::installAttribute(isolate, world, instance, prototype, attr ibute{{attribute.name}}Configuration);
547 {% else %} 546 {% else %}
548 const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Conf iguration = {{attribute_configuration(attribute)}}; 547 const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Conf iguration = {{attribute_configuration(attribute)}};
549 V8DOMConfiguration::installAccessor(isolate, world, instance, prototype, inter face, signature, accessor{{attribute.name}}Configuration); 548 V8DOMConfiguration::installAccessor(isolate, world, instance, prototype, inter face, signature, accessor{{attribute.name}}Configuration);
550 {% endif %} 549 {% endif %}
551 {% endfor %} 550 {% endfor %}
552 {# Origin-Trial-enabled constants #} 551 {# Origin-Trial-enabled constants #}
553 {% for constant in constants | for_origin_trial_feature(origin_trial_feature.n ame) | unique_by('name') | sort %} 552 {% for constant in feature.constants %}
554 {% set constant_name = constant.name.title().replace('_', '') %} 553 {% set constant_name = constant.name.title().replace('_', '') %}
555 const V8DOMConfiguration::ConstantConfiguration constant{{constant_name}}Confi guration = {{constant_configuration(constant)}}; 554 const V8DOMConfiguration::ConstantConfiguration constant{{constant_name}}Confi guration = {{constant_configuration(constant)}};
556 V8DOMConfiguration::installConstant(isolate, interface, prototype, constant{{c onstant_name}}Configuration); 555 V8DOMConfiguration::installConstant(isolate, interface, prototype, constant{{c onstant_name}}Configuration);
557 {% endfor %} 556 {% endfor %}
558 {# Origin-Trial-enabled methods (no overloads) #} 557 {# Origin-Trial-enabled methods (no overloads) #}
559 {% for method in methods | method_for_origin_trial_feature(origin_trial_featur e.name, is_partial) | unique_by('name') | sort %} 558 {% for method in feature.methods %}
560 {% set method_name = method.name.title().replace('_', '') %} 559 {% set method_name = method.name.title().replace('_', '') %}
561 const V8DOMConfiguration::MethodConfiguration method{{method_name}}Configurati on = {{method_configuration(method)}}; 560 const V8DOMConfiguration::MethodConfiguration method{{method_name}}Configurati on = {{method_configuration(method)}};
562 V8DOMConfiguration::installMethod(isolate, world, instance, prototype, interfa ce, signature, method{{method_name}}Configuration); 561 V8DOMConfiguration::installMethod(isolate, world, instance, prototype, interfa ce, signature, method{{method_name}}Configuration);
563 {% endfor %} 562 {% endfor %}
564 } 563 }
565 564
566 void {{v8_class_or_partial}}::install{{origin_trial_feature.name}}(ScriptState* scriptState, v8::Local<v8::Object> instance) { 565 void {{v8_class_or_partial}}::install{{feature.name}}(ScriptState* scriptState, v8::Local<v8::Object> instance) {
567 V8PerContextData* perContextData = V8PerContextData::from(scriptState->context ()); 566 V8PerContextData* perContextData = V8PerContextData::from(scriptState->context ());
568 v8::Local<v8::Object> prototype = perContextData->prototypeForType(&{{v8_class }}::wrapperTypeInfo); 567 v8::Local<v8::Object> prototype = perContextData->prototypeForType(&{{v8_class }}::wrapperTypeInfo);
569 v8::Local<v8::Function> interface = perContextData->constructorForType(&{{v8_c lass}}::wrapperTypeInfo); 568 v8::Local<v8::Function> interface = perContextData->constructorForType(&{{v8_c lass}}::wrapperTypeInfo);
570 ALLOW_UNUSED_LOCAL(interface); 569 ALLOW_UNUSED_LOCAL(interface);
571 install{{origin_trial_feature.name}}(scriptState->isolate(), scriptState->worl d(), instance, prototype, interface); 570 install{{feature.name}}(scriptState->isolate(), scriptState->world(), instance , prototype, interface);
572 } 571 }
573 {% if not origin_trial_feature.needs_instance %} 572 {% if not feature.needs_instance %}
574 573
575 void {{v8_class_or_partial}}::install{{origin_trial_feature.name}}(ScriptState* scriptState) { 574 void {{v8_class_or_partial}}::install{{feature.name}}(ScriptState* scriptState) {
576 install{{origin_trial_feature.name}}(scriptState, v8::Local<v8::Object>()); 575 install{{feature.name}}(scriptState, v8::Local<v8::Object>());
577 } 576 }
578 {% endif %} 577 {% endif %}
579 578
580 {% endfor %} 579 {% endfor %}{# feature #}
581 {% endblock %} 580 {% endblock %}
582 {##############################################################################} 581 {##############################################################################}
583 {% block get_dom_template %}{% endblock %} 582 {% block get_dom_template %}{% endblock %}
584 {% block get_dom_template_for_named_properties_object %}{% endblock %} 583 {% block get_dom_template_for_named_properties_object %}{% endblock %}
585 {% block has_instance %}{% endblock %} 584 {% block has_instance %}{% endblock %}
586 {% block to_impl %}{% endblock %} 585 {% block to_impl %}{% endblock %}
587 {% block to_impl_with_type_check %}{% endblock %} 586 {% block to_impl_with_type_check %}{% endblock %}
588 {##############################################################################} 587 {##############################################################################}
589 {% block prepare_prototype_and_interface_object %}{% endblock %} 588 {% block prepare_prototype_and_interface_object %}{% endblock %}
590 {##############################################################################} 589 {##############################################################################}
591 {% block partial_interface %}{% endblock %} 590 {% block partial_interface %}{% endblock %}
592 } // namespace blink 591 } // namespace blink
593 592
594 {% endfilter %}{# format_blink_cpp_source_code #} 593 {% endfilter %}{# format_blink_cpp_source_code #}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698