Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js |
| index 3e67015dfd2cbf793fc79ecf32dc0d3b07b85b48..434900121580db6c377da482154e79967e1b779d 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js |
| @@ -1255,14 +1255,15 @@ UI.DataGridNode = class extends Common.Object { |
| */ |
| element() { |
| if (!this._element) { |
| - this.createElement(); |
| - this.createCells(); |
| + var element = this.createElement(); |
| + this.createCells(element); |
|
alph
2016/12/12 23:41:37
You can do it in a single line.
|
| } |
| return /** @type {!Element} */ (this._element); |
| } |
| /** |
| * @protected |
| + * @return {!Element} |
| */ |
| createElement() { |
| this._element = createElement('tr'); |
| @@ -1276,17 +1277,19 @@ UI.DataGridNode = class extends Common.Object { |
| this._element.classList.add('selected'); |
| if (this.revealed) |
| this._element.classList.add('revealed'); |
| + return this._element; |
| } |
| /** |
| + * @param {!Element} element |
| * @protected |
| */ |
| - createCells() { |
| - this._element.removeChildren(); |
| + createCells(element) { |
| + element.removeChildren(); |
| var columnsArray = this.dataGrid._visibleColumnsArray; |
| for (var i = 0; i < columnsArray.length; ++i) |
| - this._element.appendChild(this.createCell(columnsArray[i].id)); |
| - this._element.appendChild(this._createTDWithClass('corner')); |
| + element.appendChild(this.createCell(columnsArray[i].id)); |
| + element.appendChild(this._createTDWithClass('corner')); |
| } |
| /** |
| @@ -1439,7 +1442,7 @@ UI.DataGridNode = class extends Common.Object { |
| this._element = null; |
| if (!this._element) |
| return; |
| - this.createCells(); |
| + this.createCells(this._element); |
| } |
| /** |