Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js

Issue 2573673002: DevTools: enable private field checks as a part of compilation. (Closed)
Patch Set: review comments addressed. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 Common.UIString('GPU Memory'), Common.UIString('GPU Memory [KB]: %s'), ' hsl(300, 90%, 43%)', 52 Common.UIString('GPU Memory'), Common.UIString('GPU Memory [KB]: %s'), ' hsl(300, 90%, 43%)',
53 Number.bytesToString); 53 Number.bytesToString);
54 this._countersByName['gpuMemoryUsedKB'] = this._gpuMemoryCounter; 54 this._countersByName['gpuMemoryUsedKB'] = this._gpuMemoryCounter;
55 } 55 }
56 56
57 /** 57 /**
58 * @override 58 * @override
59 */ 59 */
60 refreshRecords() { 60 refreshRecords() {
61 this.reset(); 61 this.reset();
62 var events = this._model.mainThreadEvents(); 62 var events = this.model().mainThreadEvents();
63 for (var i = 0; i < events.length; ++i) { 63 for (var i = 0; i < events.length; ++i) {
64 var event = events[i]; 64 var event = events[i];
65 if (event.name !== TimelineModel.TimelineModel.RecordType.UpdateCounters) 65 if (event.name !== TimelineModel.TimelineModel.RecordType.UpdateCounters)
66 continue; 66 continue;
67 67
68 var counters = event.args.data; 68 var counters = event.args.data;
69 if (!counters) 69 if (!counters)
70 return; 70 return;
71 for (var name in counters) { 71 for (var name in counters) {
72 var counter = this._countersByName[name]; 72 var counter = this._countersByName[name];
73 if (counter) 73 if (counter)
74 counter.appendSample(event.startTime, counters[name]); 74 counter.appendSample(event.startTime, counters[name]);
75 } 75 }
76 76
77 var gpuMemoryLimitCounterName = 'gpuMemoryLimitKB'; 77 var gpuMemoryLimitCounterName = 'gpuMemoryLimitKB';
78 if (gpuMemoryLimitCounterName in counters) 78 if (gpuMemoryLimitCounterName in counters)
79 this._gpuMemoryCounter.setLimit(counters[gpuMemoryLimitCounterName]); 79 this._gpuMemoryCounter.setLimit(counters[gpuMemoryLimitCounterName]);
80 } 80 }
81 this.scheduleRefresh(); 81 this.scheduleRefresh();
82 } 82 }
83 }; 83 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698