Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 2573653003: Remove LayoutSVGViewportContainer's calcViewport and pointIsInsideViewportClip (Closed)
Patch Set: Actually revert SVGSVGElement changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
index fe065b243022de74ecde5e120d40c83670130034..98112683664ca9df3c4904c2931b3671a6fc57a9 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
@@ -46,10 +46,7 @@ void LayoutSVGContainer::layout() {
ASSERT(needsLayout());
LayoutAnalyzer::Scope analyzer(*this);
- // Allow LayoutSVGViewportContainer to update its viewport.
- calcViewport();
-
- // Allow LayoutSVGTransformableContainer to update its transform.
+ // Update the local transform in subclasses.
SVGTransformChange transformChange = calculateLocalTransform();
m_didScreenScaleFactorChange =
transformChange == SVGTransformChange::Full ||
@@ -182,10 +179,6 @@ void LayoutSVGContainer::updateCachedBoundaries() {
bool LayoutSVGContainer::nodeAtFloatPoint(HitTestResult& result,
const FloatPoint& pointInParent,
HitTestAction hitTestAction) {
- // Give LayoutSVGViewportContainer a chance to apply its viewport clip
- if (!pointIsInsideViewportClip(pointInParent))
- return false;
-
FloatPoint localPoint;
if (!SVGLayoutSupport::transformToUserSpaceAndCheckClipping(
*this, localToSVGParentTransform(), pointInParent, localPoint))

Powered by Google App Engine
This is Rietveld 408576698