Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 2573653003: Remove LayoutSVGViewportContainer's calcViewport and pointIsInsideViewportClip (Closed)
Patch Set: Add code and TODO about removing setNeeds calls Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
index 1f85592c1822a16924f7609ad33c997bd092c3ec..d39e93c3b0b2574e8e81bbd463f0410c5d605ddb 100644
--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
@@ -281,15 +281,16 @@ void SVGSVGElement::svgAttributeChanged(const QualifiedName& attrName) {
if (SVGFitToViewBox::isKnownAttribute(attrName)) {
updateRelativeLengthsOrViewBox = true;
invalidateRelativeLengthClients();
- if (LayoutObject* object = layoutObject())
- object->setNeedsTransformUpdate();
}
if (updateRelativeLengthsOrViewBox ||
SVGZoomAndPan::isKnownAttribute(attrName)) {
SVGElement::InvalidationGuard invalidationGuard(this);
- if (layoutObject())
- markForLayoutAndParentResourceInvalidation(layoutObject());
+ if (auto* layoutObject = this->layoutObject()) {
+ markForLayoutAndParentResourceInvalidation(layoutObject);
+ layoutObject->setNeedsBoundariesUpdate();
fs 2016/12/13 10:11:23 This is a bugfix? (Well, I guess the next line is
pdr. 2016/12/13 19:48:55 This was me jumping the gun on that TODO. I've rev
+ layoutObject->setNeedsTransformUpdate();
+ }
return;
}

Powered by Google App Engine
This is Rietveld 408576698