Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_types.js

Issue 2573643005: Language settings: Fix Restart and Remove buttons shown at wrong times (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_types.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_types.js b/chrome/browser/resources/settings/languages_page/languages_types.js
index 4ee060f50880fdfd7dc9cb2525f4164ffc88df39..f3ce163a44e736b688f36acebb777c741a56b75e 100644
--- a/chrome/browser/resources/settings/languages_page/languages_types.js
+++ b/chrome/browser/resources/settings/languages_page/languages_types.js
@@ -24,9 +24,9 @@ var LanguageState;
* enabled: an array of the currently enabled input methods.
* currentId: ID of the currently active input method.
* @typedef {{
- * supported: !Array<!chrome.languageSettingsPrivate.InputMethod>,
- * enabled: !Array<!chrome.languageSettingsPrivate.InputMethod>,
- * currentId: string,
+ * supported: !Array<!chrome.languageSettingsPrivate.InputMethod>,
+ * enabled: !Array<!chrome.languageSettingsPrivate.InputMethod>,
+ * currentId: string,
* }}
*/
var InputMethodsModel;
@@ -36,11 +36,17 @@ var InputMethodsModel;
* supported: an array of languages, ordered alphabetically, set once
* at initialization.
* enabled: an array of enabled language states, ordered by preference.
+ * prospectiveUILanguage: the "prospective" UI language, i.e., the one to be
+ * used on next restart. Matches the current UI language preference unless
+ * the user has chosen a different language without restarting. May differ
+ * from the actually used language (navigator.language). Chrome OS and
+ * Windows only.
* translateTarget: the default language to translate into.
* inputMethods: the InputMethodsModel (Chrome OS only).
* @typedef {{
* supported: !Array<!chrome.languageSettingsPrivate.Language>,
* enabled: !Array<!LanguageState>,
+ * prospectiveUILanguage: string,
* translateTarget: string,
* inputMethods: (!InputMethodsModel|undefined),
* }}
@@ -63,18 +69,16 @@ LanguageHelper.prototype = {
* the actual UI language until a restart.
* @param {string} languageCode
*/
- setUILanguage: assertNotReached,
+ setProspectiveUILanguage: assertNotReached,
- /** Resets the prospective UI language back to the actual UI language. */
- resetUILanguage: assertNotReached,
+ /** Resets the prospective UI language back to its starting value. */
+ resetProspectiveUILanguage: assertNotReached,
/**
- * Returns the "prospective" UI language, i.e. the one to be used on next
- * restart. If the pref is not set, the current UI language is also the
- * "prospective" language.
- * @return {string} Language code of the prospective UI language.
+ * True if the prospective UI language has been changed.
+ * @return {boolean}
*/
- getProspectiveUILanguage: assertNotReached,
+ requiresRestart: assertNotReached,
/**
* @param {string} languageCode
@@ -187,13 +191,4 @@ LanguageHelper.prototype = {
/** @param {string} id Input method ID. */
openInputMethodOptions: assertNotReached,
-
- /** @param {string} id New current input method ID. */
- onInputMethodChanged_: assertNotReached,
-
- /** @param {string} id Added input method ID. */
- onInputMethodAdded_: assertNotReached,
-
- /** @param {string} id Removed input method ID. */
- onInputMethodRemoved_: assertNotReached,
};

Powered by Google App Engine
This is Rietveld 408576698