Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: chrome/test/data/webui/settings/languages_tests.js

Issue 2573643005: Language settings: Fix Restart and Remove buttons shown at wrong times (Closed)
Patch Set: feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/languages_handler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('settings-languages', function() { 5 cr.define('settings-languages', function() {
6 /** 6 /**
7 * Data-binds two Polymer properties using the property-changed events and 7 * Data-binds two Polymer properties using the property-changed events and
8 * set/notifyPath API. Useful for testing components which would normally be 8 * set/notifyPath API. Useful for testing components which would normally be
9 * used together. 9 * used together.
10 * @param {!HTMLElement} el1 10 * @param {!HTMLElement} el1
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 83
84 setup(function() { 84 setup(function() {
85 var settingsPrefs = document.createElement('settings-prefs'); 85 var settingsPrefs = document.createElement('settings-prefs');
86 var settingsPrivate = new settings.FakeSettingsPrivate(getFakePrefs()); 86 var settingsPrivate = new settings.FakeSettingsPrivate(getFakePrefs());
87 settingsPrefs.initialize(settingsPrivate); 87 settingsPrefs.initialize(settingsPrivate);
88 88
89 languageSettingsPrivate = new settings.FakeLanguageSettingsPrivate(); 89 languageSettingsPrivate = new settings.FakeLanguageSettingsPrivate();
90 languageSettingsPrivate.setSettingsPrefs(settingsPrefs); 90 languageSettingsPrivate.setSettingsPrefs(settingsPrefs);
91 settings.languageSettingsPrivateApiForTest = languageSettingsPrivate; 91 settings.languageSettingsPrivateApiForTest = languageSettingsPrivate;
92 92
93 var getProspectiveUILanguageCalled = false;
94 registerMessageCallback('getProspectiveUILanguage', null,
95 function(callbackId) {
96 assertFalse(getProspectiveUILanguageCalled);
97 getProspectiveUILanguageCalled = true;
98 cr.webUIResponse(callbackId, true, 'en-US');
99 });
100
93 languageHelper = document.createElement('settings-languages'); 101 languageHelper = document.createElement('settings-languages');
94 102
95 // Prefs would normally be data-bound to settings-languages. 103 // Prefs would normally be data-bound to settings-languages.
96 fakeDataBind(settingsPrefs, languageHelper, 'prefs'); 104 fakeDataBind(settingsPrefs, languageHelper, 'prefs');
97 105
98 return languageHelper.whenReady(); 106 return languageHelper.whenReady().then(function() {
107 assertEquals(
108 cr.isChromeOS || cr.isWindows, getProspectiveUILanguageCalled);
109 });
99 }); 110 });
100 111
101 test('languages model', function() { 112 test('languages model', function() {
102 for (var i = 0; i < languageSettingsPrivate.languages.length; 113 for (var i = 0; i < languageSettingsPrivate.languages.length;
103 i++) { 114 i++) {
104 assertEquals(languageSettingsPrivate.languages[i].code, 115 assertEquals(languageSettingsPrivate.languages[i].code,
105 languageHelper.languages.supported[i].code); 116 languageHelper.languages.supported[i].code);
106 } 117 }
107 assertLanguageOrder(['en-US', 'sw']); 118 assertLanguageOrder(['en-US', 'sw']);
108 assertEquals('en', languageHelper.languages.translateTarget); 119 assertEquals('en', languageHelper.languages.translateTarget);
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 // The US Swahili keyboard should still be enabled, because it supports 195 // The US Swahili keyboard should still be enabled, because it supports
185 // English which is still enabled. 196 // English which is still enabled.
186 assertTrue(languageHelper.languages.inputMethods.enabled.some( 197 assertTrue(languageHelper.languages.inputMethods.enabled.some(
187 function(inputMethod) { 198 function(inputMethod) {
188 return inputMethod.id == swUS; 199 return inputMethod.id == swUS;
189 })); 200 }));
190 }); 201 });
191 } 202 }
192 }); 203 });
193 }); 204 });
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/settings/languages_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698