Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2573643005: Language settings: Fix Restart and Remove buttons shown at wrong times (Closed)
Patch Set: feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/assert.html"> 2 <link rel="import" href="chrome://resources/html/assert.html">
3 <link rel="import" href="chrome://resources/html/cr.html"> 3 <link rel="import" href="chrome://resources/html/cr.html">
4 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
9 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 9 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 language-helper="{{languageHelper}}"> 70 language-helper="{{languageHelper}}">
71 </settings-languages> 71 </settings-languages>
72 <settings-animated-pages id="pages" section="languages"> 72 <settings-animated-pages id="pages" section="languages">
73 <neon-animatable route-path="default"> 73 <neon-animatable route-path="default">
74 <div class$="settings-box first [[getLanguageListTwoLine_()]]" 74 <div class$="settings-box first [[getLanguageListTwoLine_()]]"
75 actionable on-tap="toggleExpandButton_"> 75 actionable on-tap="toggleExpandButton_">
76 <div class="start"> 76 <div class="start">
77 <div>$i18n{languagesListTitle}</div> 77 <div>$i18n{languagesListTitle}</div>
78 <if expr="chromeos or is_win"> 78 <if expr="chromeos or is_win">
79 <div class="secondary"> 79 <div class="secondary">
80 [[getProspectiveUILanguageName_( 80 [[getProspectiveUILanguageName_(languages.prospectiveUILanguage)]]
81 languages, prefs.intl.app_locale.value)]]
82 </div> 81 </div>
83 </if> 82 </if>
84 </div> 83 </div>
85 <cr-expand-button expanded="{{languagesOpened_}}" 84 <cr-expand-button expanded="{{languagesOpened_}}"
86 alt="$i18n{languagesExpandA11yLabel}"> 85 alt="$i18n{languagesExpandA11yLabel}">
87 </cr-expand-button> 86 </cr-expand-button>
88 </div> 87 </div>
89 <iron-collapse id="languagesCollapse" opened="[[languagesOpened_]]"> 88 <iron-collapse id="languagesCollapse" opened="[[languagesOpened_]]">
90 <div class="list-frame vertical-list"> 89 <div class="list-frame vertical-list">
91 <span class="list-item" 90 <span class="list-item"
92 hidden="[[isHelpTextHidden_(languages.enabled.*)]]"> 91 hidden="[[isHelpTextHidden_(languages.enabled.*)]]">
93 <span>$i18n{orderLanguagesInstructions}</span> 92 <span>$i18n{orderLanguagesInstructions}</span>
94 <if expr="chromeos"> 93 <if expr="chromeos">
95 <a href="$i18n{languagesLearnMoreURL}" target="_blank"> 94 <a href="$i18n{languagesLearnMoreURL}" target="_blank">
96 $i18n{learnMore} 95 $i18n{learnMore}
97 </a> 96 </a>
98 </if> 97 </if>
99 </span> 98 </span>
100 <template is="dom-repeat" items="[[languages.enabled]]"> 99 <template is="dom-repeat" items="[[languages.enabled]]">
101 <div class$="list-item [[getLanguageItemClass_( 100 <div class$="list-item [[getLanguageItemClass_(
102 item.language.code, prefs.intl.app_locale.value, 101 item.language.code, language.prospectiveUILanguage)]]">
103 item.language.supportsUI)]]">
104 <div class="start"> 102 <div class="start">
105 <div title="[[item.language.nativeDisplayName]]"> 103 <div title="[[item.language.nativeDisplayName]]">
106 [[item.language.displayName]] 104 [[item.language.displayName]]
107 </div> 105 </div>
108 <if expr="chromeos or is_win"> 106 <if expr="chromeos or is_win">
109 <div class="explain-selected" 107 <div class="explain-selected"
110 hidden="[[!isProspectiveUILanguage_( 108 hidden="[[!isProspectiveUILanguage_(
111 item.language.code, prefs.intl.app_locale.value)]]"> 109 item.language.code,
110 languages.prospectiveUILanguage)]]">
112 $i18n{isDisplayedInThisLanguage} 111 $i18n{isDisplayedInThisLanguage}
113 </div> 112 </div>
114 </if> 113 </if>
115 </div> 114 </div>
116 <if expr="chromeos or is_win"> 115 <if expr="chromeos or is_win">
117 <template is="dom-if" if="[[isRestartRequired_( 116 <template is="dom-if" if="[[isRestartRequired_(
118 item.language.code, prefs.intl.app_locale.value)]]"> 117 item.language.code, languages.prospectiveUILanguage)]]">
119 <paper-button on-tap="onRestartTap_"> 118 <paper-button on-tap="onRestartTap_">
120 $i18n{restart} 119 $i18n{restart}
121 </paper-button> 120 </paper-button>
122 </template> 121 </template>
123 </if> 122 </if>
124 <paper-icon-button id="more-[[item.language.code]]" 123 <paper-icon-button id="more-[[item.language.code]]"
125 icon="cr:more-vert" on-tap="onDotsTap_"> 124 icon="cr:more-vert" on-tap="onDotsTap_">
126 </paper-icon-button> 125 </paper-icon-button>
127 </div> 126 </div>
128 </template> 127 </template>
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 </div> 205 </div>
207 </iron-collapse> 206 </iron-collapse>
208 </if> 207 </if>
209 <template is="cr-lazy-render" id="menu"> 208 <template is="cr-lazy-render" id="menu">
210 <dialog is="cr-action-menu" 209 <dialog is="cr-action-menu"
211 class$="[[getMenuClass_(prefs.translate.enabled.value)]]"> 210 class$="[[getMenuClass_(prefs.translate.enabled.value)]]">
212 <if expr="chromeos or is_win"> 211 <if expr="chromeos or is_win">
213 <paper-checkbox id="uiLanguageItem" class="dropdown-item" 212 <paper-checkbox id="uiLanguageItem" class="dropdown-item"
214 checked="[[isProspectiveUILanguage_( 213 checked="[[isProspectiveUILanguage_(
215 detailLanguage_.language.code, 214 detailLanguage_.language.code,
216 prefs.intl.app_locale.value)]]" 215 languages.prospectiveUILanguage)]]"
217 on-change="onUILanguageChange_" 216 on-change="onUILanguageChange_"
218 disabled="[[disableUILanguageCheckbox_( 217 disabled="[[disableUILanguageCheckbox_(
219 detailLanguage_, prefs.intl.app_locale.value)]]"> 218 detailLanguage_, languages.prospectiveUILanguage)]]">
220 $i18n{displayInThisLanguage} 219 $i18n{displayInThisLanguage}
221 </paper-checkbox> 220 </paper-checkbox>
222 </if> 221 </if>
223 <paper-checkbox id="offerTranslations" class="dropdown-item" 222 <paper-checkbox id="offerTranslations" class="dropdown-item"
224 checked="[[detailLanguage_.translateEnabled]]" 223 checked="[[detailLanguage_.translateEnabled]]"
225 on-change="onTranslateCheckboxChange_" 224 on-change="onTranslateCheckboxChange_"
226 hidden="[[!prefs.translate.enabled.value]]" 225 hidden="[[!prefs.translate.enabled.value]]"
227 disabled="[[disableTranslateCheckbox_( 226 disabled="[[disableTranslateCheckbox_(
228 detailLanguage_.language, languages.translateTarget)]]"> 227 detailLanguage_.language, languages.translateTarget)]]">
229 $i18n{offerToTranslateInThisLanguage} 228 $i18n{offerToTranslateInThisLanguage}
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 </if> 276 </if>
278 </settings-animated-pages> 277 </settings-animated-pages>
279 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 278 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
280 <settings-add-languages-dialog languages="{{languages}}" 279 <settings-add-languages-dialog languages="{{languages}}"
281 language-helper="[[languageHelper]]"> 280 language-helper="[[languageHelper]]">
282 </settings-add-languages-dialog> 281 </settings-add-languages-dialog>
283 </template> 282 </template>
284 </template> 283 </template>
285 <script src="languages_page.js"></script> 284 <script src="languages_page.js"></script>
286 </dom-module> 285 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698