Add support to dump font cache texture for debug purposes

Add support to dump font cache texture for debug purposes

Committed: http://code.google.com/p/skia/source/detail?r=11579

[robertphillips, 2013-10-02 15:07:28]

lgtm + questions, suggestions & nits

https://codereview.chromium.org/25736002/diff/1/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/25736002/diff/1/include/gpu/GrContext.h#newco...
include/gpu/GrContext.h:630: 
#ifdef SK_DEBUG? DEV?
const?

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrAtlas.cpp
File src/gpu/GrAtlas.cpp (right):

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrAtlas.cpp#newcode181
src/gpu/GrAtlas.cpp:181: GrTextureDesc desc;
Do we always want this or just sometimes?
Do we need a comment like "// A RT just so that we can write out the pixels?"

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrContext.cpp#newcode645
src/gpu/GrContext.cpp:645: 
SK_DEBUG? DEV?

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrTextStrike.cpp
File src/gpu/GrTextStrike.cpp (right):

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrTextStrike.cpp#newc...
src/gpu/GrTextStrike.cpp:173: 
SK_DEBUG? DEV?

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrTextStrike.cpp#newc...
src/gpu/GrTextStrike.cpp:174: void GrFontCache::dump() const {
I feel this needs some fancy naming: gDumpCount, sDumpCount?

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrTextStrike.cpp#newc...
src/gpu/GrTextStrike.cpp:176: for (int i = 0; i < kMaskFormatCount; ++i) {
NULL !=

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrTextStrike.cpp#newc...
src/gpu/GrTextStrike.cpp:178: GrTexture* texture = fAtlasMgr[i]->getTexture();
NULL !=

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrTextStrike.cpp#newc...
src/gpu/GrTextStrike.cpp:180: SkString filename;
Would it be more helpful to convert the mask format to a short text string?

[jvanverth1, 2013-10-02 15:12:08]

https://codereview.chromium.org/25736002/diff/1/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/25736002/diff/1/include/gpu/GrContext.h#newco...
include/gpu/GrContext.h:630: 
On 2013/10/02 15:07:28, robertphillips wrote:
> #ifdef SK_DEBUG? DEV?
> const?

I'd like to be able to use this in release builds.

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrAtlas.cpp
File src/gpu/GrAtlas.cpp (right):

https://codereview.chromium.org/25736002/diff/1/src/gpu/GrAtlas.cpp#newcode181
src/gpu/GrAtlas.cpp:181: GrTextureDesc desc;
On 2013/10/02 15:07:28, robertphillips wrote:
> Do we always want this or just sometimes?
> Do we need a comment like "// A RT just so that we can write out the pixels?"

In order for dump() to work, it has to be there. What is the cost of adding it?

[jvanverth1, 2013-10-02 15:39:00]

Adding Brian since this changes a public GPU interface.

[robertphillips, 2013-10-02 15:50:18]

lgtm

[bsalomon, 2013-10-02 16:09:32]

lgtm w/ one suggestion.

https://codereview.chromium.org/25736002/diff/10001/src/gpu/GrAtlas.cpp
File src/gpu/GrAtlas.cpp (right):

https://codereview.chromium.org/25736002/diff/10001/src/gpu/GrAtlas.cpp#newco...
src/gpu/GrAtlas.cpp:184: desc.fFlags =
kDynamicUpdate_GrTextureFlagBit|kRenderTarget_GrTextureFlagBit;
|kNoStencil_GrTextureFlagBit

[commit-bot: I haz the power, 2013-10-02 17:50:54]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/25736002/24001

[commit-bot: I haz the power, 2013-10-02 18:19:19]

Change committed as 11579