[stubs] Enable graph verification for builtins.

src/builtins/builtins-sharedarraybuffer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins-utils.h"
 #include "src/builtins/builtins.h"
 #include "src/code-factory.h"
 #include "src/code-stub-assembler.h"
 
 namespace v8 {
@@ skipping 25 matching lines @@
       not_typed_array(a), is_shared(a), not_shared(a), is_float_or_clamped(a),
       not_float_or_clamped(a), invalid(a);
 
   // Fail if it is not a heap object.
   a->Branch(a->TaggedIsSmi(tagged), &is_smi, &not_smi);
   a->Bind(&is_smi);
   a->Goto(&invalid);
 
   // Fail if the array's instance type is not JSTypedArray.
   a->Bind(&not_smi);
-  a->Branch(a->WordEqual(a->LoadInstanceType(tagged),
-                         a->Int32Constant(JS_TYPED_ARRAY_TYPE)),
+  a->Branch(a->Word32Equal(a->LoadInstanceType(tagged),
+                           a->Int32Constant(JS_TYPED_ARRAY_TYPE)),
             &is_typed_array, &not_typed_array);
   a->Bind(&not_typed_array);
   a->Goto(&invalid);
 
   // Fail if the array's JSArrayBuffer is not shared.
   a->Bind(&is_typed_array);
   Node* array_buffer = a->LoadObjectField(tagged, JSTypedArray::kBufferOffset);
   Node* is_buffer_shared =
       a->IsSetWord32<JSArrayBuffer::IsShared>(a->LoadObjectField(
           array_buffer, JSArrayBuffer::kBitFieldOffset, MachineType::Uint32()));
@@ skipping 23 matching lines @@
   a->Return(a->UndefinedConstant());
 
   a->Bind(&not_float_or_clamped);
   *out_instance_type = elements_instance_type;
 
   Node* backing_store =
       a->LoadObjectField(array_buffer, JSArrayBuffer::kBackingStoreOffset);
   Node* byte_offset = a->ChangeUint32ToWord(a->TruncateTaggedToWord32(
       context,
       a->LoadObjectField(tagged, JSArrayBufferView::kByteOffsetOffset)));
-  *out_backing_store = a->IntPtrAdd(backing_store, byte_offset);
+  *out_backing_store =
+      a->IntPtrAdd(a->BitcastTaggedToWord(backing_store), byte_offset);
 }
 
 // https://tc39.github.io/ecmascript_sharedmem/shmem.html#Atomics.ValidateAtomicAccess
 compiler::Node* ConvertTaggedAtomicIndexToWord32(CodeStubAssembler* a,
                                                  compiler::Node* tagged,
                                                  compiler::Node* context) {
   using compiler::Node;
   CodeStubAssembler::Variable var_result(a, MachineRepresentation::kWord32);
 
   Callable to_number = CodeFactory::ToNumber(a->isolate());
@@ skipping 35 matching lines @@
 }
 
 void ValidateAtomicIndex(CodeStubAssembler* a, compiler::Node* index_word,
                          compiler::Node* array_length_word,
                          compiler::Node* context) {
   using compiler::Node;
   // Check if the index is in bounds. If not, throw RangeError.
   CodeStubAssembler::Label if_inbounds(a), if_notinbounds(a);
   // TODO(jkummerow): Use unsigned comparison instead of "i<0 || i>length".
   a->Branch(
-      a->WordOr(a->Int32LessThan(index_word, a->Int32Constant(0)),
-                a->Int32GreaterThanOrEqual(index_word, array_length_word)),
+      a->Word32Or(a->Int32LessThan(index_word, a->Int32Constant(0)),
+                  a->Int32GreaterThanOrEqual(index_word, array_length_word)),
       &if_notinbounds, &if_inbounds);
   a->Bind(&if_notinbounds);
   a->Return(
       a->CallRuntime(Runtime::kThrowInvalidAtomicAccessIndexError, context));
   a->Bind(&if_inbounds);
 }
 
 }  // anonymous namespace
 
 void Builtins::Generate_AtomicsLoad(compiler::CodeAssemblerState* state) {
@@ skipping 19 matching lines @@
       FIXED_INT8_ARRAY_TYPE,   FIXED_UINT8_ARRAY_TYPE, FIXED_INT16_ARRAY_TYPE,
       FIXED_UINT16_ARRAY_TYPE, FIXED_INT32_ARRAY_TYPE, FIXED_UINT32_ARRAY_TYPE,
   };
   CodeStubAssembler::Label* case_labels[] = {
       &i8, &u8, &i16, &u16, &i32, &u32,
   };
   a.Switch(instance_type, &other, case_values, case_labels,
            arraysize(case_labels));
 
   a.Bind(&i8);
-  a.Return(
-      a.SmiTag(a.AtomicLoad(MachineType::Int8(), backing_store, index_word)));
+  a.Return(a.SmiFromWord32(
+      a.AtomicLoad(MachineType::Int8(), backing_store, index_word)));
 
   a.Bind(&u8);
-  a.Return(
-      a.SmiTag(a.AtomicLoad(MachineType::Uint8(), backing_store, index_word)));
+  a.Return(a.SmiFromWord32(
+      a.AtomicLoad(MachineType::Uint8(), backing_store, index_word)));
 
   a.Bind(&i16);
-  a.Return(a.SmiTag(a.AtomicLoad(MachineType::Int16(), backing_store,
-                                 a.WordShl(index_word, 1))));
+  a.Return(a.SmiFromWord32(a.AtomicLoad(MachineType::Int16(), backing_store,
+                                        a.WordShl(index_word, 1))));
 
   a.Bind(&u16);
-  a.Return(a.SmiTag(a.AtomicLoad(MachineType::Uint16(), backing_store,
-                                 a.WordShl(index_word, 1))));
+  a.Return(a.SmiFromWord32(a.AtomicLoad(MachineType::Uint16(), backing_store,
+                                        a.WordShl(index_word, 1))));
 
   a.Bind(&i32);
   a.Return(a.ChangeInt32ToTagged(a.AtomicLoad(
       MachineType::Int32(), backing_store, a.WordShl(index_word, 2))));
 
   a.Bind(&u32);
   a.Return(a.ChangeUint32ToTagged(a.AtomicLoad(
       MachineType::Uint32(), backing_store, a.WordShl(index_word, 2))));
 
   // This shouldn't happen, we've already validated the type.
   a.Bind(&other);
-  a.Return(a.Int32Constant(0));
+  a.Return(a.SmiConstant(0));
 }
 
 void Builtins::Generate_AtomicsStore(compiler::CodeAssemblerState* state) {
   using compiler::Node;
   CodeStubAssembler a(state);
   Node* array = a.Parameter(1);
   Node* index = a.Parameter(2);
   Node* value = a.Parameter(3);
   Node* context = a.Parameter(4 + 2);
 
@@ skipping 31 matching lines @@
                 a.WordShl(index_word, 1), value_word32);
   a.Return(value_integer);
 
   a.Bind(&u32);
   a.AtomicStore(MachineRepresentation::kWord32, backing_store,
                 a.WordShl(index_word, 2), value_word32);
   a.Return(value_integer);
 
   // This shouldn't happen, we've already validated the type.
   a.Bind(&other);
-  a.Return(a.Int32Constant(0));
+  a.Return(a.SmiConstant(0));
 }
 
 }  // namespace internal
 }  // namespace v8