Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/public/platform/modules/permissions/permission.mojom

Issue 2573573002: Switch PermissionStatus events to an observer model. (Closed)
Patch Set: Rebased. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/permissions/permission.mojom
diff --git a/third_party/WebKit/public/platform/modules/permissions/permission.mojom b/third_party/WebKit/public/platform/modules/permissions/permission.mojom
index ef429379f97c3836ee0ef8b504482fcac89ff004..97387f9813687a9abfb7ab18e4248291f8ab9c49 100644
--- a/third_party/WebKit/public/platform/modules/permissions/permission.mojom
+++ b/third_party/WebKit/public/platform/modules/permissions/permission.mojom
@@ -35,6 +35,11 @@ struct PermissionDescriptor {
PermissionDescriptorExtension? extension;
};
+// Interface a client can implement to observe permission changes.
+interface PermissionObserver {
+ OnPermissionStatusChange(PermissionStatus status);
+};
+
// The Permission service provides permission handling capabilities by exposing
// methods to check, request, and revoke permissions. It also allows a client to
// start listening to permission changes.
@@ -49,13 +54,10 @@ interface PermissionService {
=> (array<PermissionStatus> statuses);
RevokePermission(PermissionDescriptor permission, url.mojom.Origin origin)
=> (PermissionStatus status);
-
- // Runs the callback next time there is a permission status change for the
- // given { permission, origin }. Callers of this method will have to call it
- // again if they want to keep listening to the changes. To prevent race
- // conditions, the caller must pass the last known value.
- GetNextPermissionChange(PermissionDescriptor permission,
- url.mojom.Origin origin,
- PermissionStatus last_known_status)
- => (PermissionStatus status);
+ // Subscribes |observer| to updates about changes to |origin|'s access to
+ // |permission|. Closing the pipe will cancel the subscription.
+ AddPermissionObserver(PermissionDescriptor permission,
+ url.mojom.Origin origin,
+ PermissionStatus last_known_status,
+ PermissionObserver observer);
};
« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698