Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

Issue 2573573002: Switch PermissionStatus events to an observer model. (Closed)
Patch Set: Remove call to registerPreFinalizer(). Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/PermissionStatus.h
diff --git a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
index 910db817b9d52459531ec85b63ae54def3b80585..2a94090558327cad1c646faf28293df225ddd6bd 100644
--- a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
+++ b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
@@ -8,6 +8,7 @@
#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "core/dom/SuspendableObject.h"
#include "core/events/EventTarget.h"
+#include "mojo/public/cpp/bindings/binding.h"
#include "platform/heap/Handle.h"
#include "public/platform/modules/permissions/permission.mojom-blink.h"
#include "wtf/text/AtomicString.h"
@@ -22,9 +23,11 @@ class ScriptPromiseResolver;
// ExecutionContext.
class PermissionStatus final : public EventTargetWithInlineData,
public ActiveScriptWrappable,
- public SuspendableObject {
+ public SuspendableObject,
+ public mojom::blink::PermissionObserver {
USING_GARBAGE_COLLECTED_MIXIN(PermissionStatus);
DEFINE_WRAPPERTYPEINFO();
+ USING_PRE_FINALIZER(PermissionStatus, dispose);
using MojoPermissionDescriptor = mojom::blink::PermissionDescriptorPtr;
using MojoPermissionStatus = mojom::blink::PermissionStatus;
@@ -38,6 +41,7 @@ class PermissionStatus final : public EventTargetWithInlineData,
MojoPermissionStatus,
MojoPermissionDescriptor);
~PermissionStatus() override;
+ void dispose();
// EventTarget implementation.
const AtomicString& interfaceName() const override;
@@ -52,7 +56,6 @@ class PermissionStatus final : public EventTargetWithInlineData,
void contextDestroyed() override;
String state() const;
- void permissionChanged(MojoPermissionStatus);
DEFINE_ATTRIBUTE_EVENT_LISTENER(change);
@@ -66,9 +69,11 @@ class PermissionStatus final : public EventTargetWithInlineData,
void startListening();
void stopListening();
+ void OnPermissionStatusChange(MojoPermissionStatus);
+
MojoPermissionStatus m_status;
MojoPermissionDescriptor m_descriptor;
- mojom::blink::PermissionServicePtr m_service;
+ mojo::Binding<mojom::blink::PermissionObserver> m_binding;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698