Add text autosizing override in the inspector.

Add text autosizing override in the inspector.

This patch adds a checkbox to the inspector for enabling text
autosizing. Screenshot: http://pr.gg/inspectortextautosizing.png

This patch has two components:
1) Changes in the inspector that add the new checkbox on the Overrides
page. This checkbox has been wired up to call two methods on
InspectorPageAgent (setTextAutosizingOverride and
clearTextAutosizingOverride). I explored just having a single
checkbox but I think that will be confusing for users.
2) Blink's Settings have been changed to support overriding the
text autosizing enabled boolean. A ternary enum has been added to
track whether the text autosizing feature is not overridden, overridden
as true, or overridden as false. Due to Blink's style guide, the
m_textAutosizingOverride variable must be declared as unsigned.

** Do not submit yet**
This is blocked on a text autosizing bug but is otherwise up for review.

BUG=302005

[pdr., 2013-10-04 02:28:28]

pfeldman, dgozman, would you be up for an initial review of this?

[caseq, 2013-10-04 02:46:33]

https://codereview.chromium.org/25735003/diff/4001/Source/devtools/protocol.json
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/25735003/diff/4001/Source/devtools/protocol.j...
Source/devtools/protocol.json:451: { "name": "enabled", "type": "boolean",
"description": "True for enabling the text autosizing override." }
Nit: you probably meant "True for enabling the text autosizing".

[pdr., 2013-10-04 02:52:17]

On 2013/10/04 02:46:33, caseq wrote:
> Nit: you probably meant "True for enabling the text autosizing".

Thanks, fixed :)

[dgozman, 2013-10-04 06:39:57]

Thank you for doing this, Philip!

My plan was to wire this to Device Metrics override, since it's really used only
on Android.
Also, there is setTextAutosizingFontScaleFactor, and we could use a slider for
this (like it's done on Clank settings screen).

Do you think the separate text autosizing section has a good use case?

[pdr., 2013-10-04 21:34:01]

On 2013/10/04 06:39:57, dgozman wrote:
> Thank you for doing this, Philip!
> 
> My plan was to wire this to Device Metrics override, since it's really used
only
> on Android.
> Also, there is setTextAutosizingFontScaleFactor, and we could use a slider for
> this (like it's done on Clank settings screen).
> 
> Do you think the separate text autosizing section has a good use case?

I think putting everything under device metrics is quite reasonable. Today, it's
not really possible to simulate what a phone will look like on desktop, nor what
a desktop will look like on a phone, and this will roughly give developers that
ability.

Let me have a go at wiring this under the device metrics section.

Two questions:
1) Is the "Font Scale Factor" that's in the inspector today useful in any way?
2) Is the text autosizing font scale factor actually useful? Today, it's buried
pretty deep under the accessibility settings on Clank so I'm not sure if it's
warrants being exposed to all developers in the inspector UI.

[dgozman, 2013-10-05 21:09:50]

On 2013/10/04 21:34:01, pdr wrote:
> On 2013/10/04 06:39:57, dgozman wrote:
> > Thank you for doing this, Philip!
> > 
> > My plan was to wire this to Device Metrics override, since it's really used
> only
> > on Android.
> > Also, there is setTextAutosizingFontScaleFactor, and we could use a slider
for
> > this (like it's done on Clank settings screen).
> > 
> > Do you think the separate text autosizing section has a good use case?
> 
> I think putting everything under device metrics is quite reasonable. Today,
it's
> not really possible to simulate what a phone will look like on desktop, nor
what
> a desktop will look like on a phone, and this will roughly give developers
that
> ability.
> 
> Let me have a go at wiring this under the device metrics section.
Sure, go ahead. Be aware of the https://codereview.chromium.org/23187005/
though, which changes device metrics override internals.

> 
> Two questions:
> 1) Is the "Font Scale Factor" that's in the inspector today useful in any way?
No, it's not.
> 2) Is the text autosizing font scale factor actually useful? Today, it's
buried
> pretty deep under the accessibility settings on Clank so I'm not sure if it's
> warrants being exposed to all developers in the inspector UI.
I'm not sure. Probably, it's not very useful. Maybe Pavel has idea about this?

[pdr., 2013-10-07 21:13:16]

On 2013/10/05 21:09:50, dgozman wrote:

Thanks for this info. https://codereview.chromium.org/23187005 pretty much
changes everything, so I'll re-do this patch once that lands.

[pdr., 2013-10-14 04:52:42]

On 2013/10/07 21:13:16, pdr wrote:
> On 2013/10/05 21:09:50, dgozman wrote:
> 
> Thanks for this info. https://codereview.chromium.org/23187005 pretty much
> changes everything, so I'll re-do this patch once that lands.

This patch has been superseded by https://codereview.chromium.org/26929003

[pfeldman, 2013-10-17 17:09:54]

> This patch has been superseded by https://codereview.chromium.org/26929003

Close it?