Issue 2573483004: Fixed build issue introduced with last commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2573483004: Fixed build issue introduced with last commit. (Closed)

Created:
4 years ago by bkonyi

Modified:
4 years ago

Reviewers:
zra, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed build issue introduced with last commit. BUG= R=johnmccutchan@google.com, zra@google.com Committed: https://github.com/dart-lang/sdk/commit/69be515447b2c19a1309a8b184f10f8014c0bb23

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated format string to reflect actual type. #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/thread.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bkonyi

Committed patchset #1 (id:1) manually as 69be515447b2c19a1309a8b184f10f8014c0bb23 (presubmit successful).

4 years ago (2016-12-12 18:32:10 UTC) #6

zra

4 years ago (2016-12-12 18:36:35 UTC) #7

Message was sent while issue was closed.

Oops. These format specifiers can be very fiddly =(

https://codereview.chromium.org/2573483004/diff/1/runtime/vm/thread.cc
File runtime/vm/thread.cc (right):

https://codereview.chromium.org/2573483004/diff/1/runtime/vm/thread.cc#newcod...
runtime/vm/thread.cc:214: jsobj.AddPropertyF("id", "threads/%" Pd64 "",
Now that we actually have an intptr_t. This can just be Pd instead of Pd64.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages