Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2573333002: GCM: Add Android UMA, and UMA for deleted/collapsed messages (Closed)

Created:
4 years ago by johnme
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

GCM: Add Android UMA, and UMA for deleted/collapsed messages - Adds GCM.DeletedMessagesReceived UMA for incoming DELETED_MESSAGES, which happens when the 100 non-collapsible messages limit is exceeded on the GCM server. - Adds GCM.DataMessageReceivedHasCollapseKey UMA for incoming messages with collapse_key, giving a baseline to compare the previous UMA with. - Makes the existing GCM.DataMessageReceivedHasRegisteredApp and GCM.DataMessageReceived UMAs only count DATA_MESSAGE rather than DELETED_MESSAGES, to better match their names (and be more useful). - Also adds all of the above UMAs to Android, which used to have no UMA. BUG=672067 Review-Url: https://codereview.chromium.org/2558553002 Cr-Commit-Position: refs/heads/master@{#438339} (cherry picked from commit 409dc538bb1495c458a72f7e93eb9e1dab102036) Committed: https://chromium.googlesource.com/chromium/src/+/5b6db9c7dfd03651ccbad98eb27a7daf4b8de8e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -19 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/GcmUma.java View 2 chunks +26 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_client_impl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_client_impl.cc View 4 chunks +29 lines, -4 lines 0 comments Download
M components/gcm_driver/gcm_stats_recorder_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M google_apis/gcm/monitoring/gcm_stats_recorder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
4 years ago (2016-12-15 00:26:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b6db9c7dfd03651ccbad98eb27a7daf4b8de8e2 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698