Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: chrome/browser/extensions/chrome_extension_function.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extension_function.h
diff --git a/chrome/browser/extensions/chrome_extension_function.h b/chrome/browser/extensions/chrome_extension_function.h
index 40fc5391c0b49ea8ca68a9fdd33a9008e82676a5..6536a7659b17740a35408d06eb74681896ab331b 100644
--- a/chrome/browser/extensions/chrome_extension_function.h
+++ b/chrome/browser/extensions/chrome_extension_function.h
@@ -18,11 +18,11 @@ namespace extensions {
class WindowController;
}
-// A chrome specific analog to AsyncExtensionFunction. This has access
-// the a chrome Profile.
-class ChromeAsyncExtensionFunction : public UIThreadExtensionFunction {
+// A chrome specific analog to AsyncExtensionFunction. This has access to a
+// chrome Profile.
+class ChromeUIThreadExtensionFunction : public UIThreadExtensionFunction {
public:
- ChromeAsyncExtensionFunction();
+ ChromeUIThreadExtensionFunction();
Profile* GetProfile() const;
@@ -59,21 +59,39 @@ class ChromeAsyncExtensionFunction : public UIThreadExtensionFunction {
virtual content::WebContents* GetAssociatedWebContents() OVERRIDE;
protected:
+ virtual ~ChromeUIThreadExtensionFunction();
+};
+
+// A chrome specific analog to AsyncExtensionFunction. This has access to a
+// chrome Profile.
+class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
+ public:
+ ChromeAsyncExtensionFunction();
+
+ protected:
virtual ~ChromeAsyncExtensionFunction();
+
+ // Deprecated, see AsyncExtensionFunction::RunAsync.
+ virtual bool RunAsync() = 0;
+
+ private:
+ virtual ResponseAction Run() OVERRIDE;
};
-// A chrome specific analog to SyncExtensionFunction. This has access
-// the a chrome Profile.
-class ChromeSyncExtensionFunction : public ChromeAsyncExtensionFunction {
+// A chrome specific analog to SyncExtensionFunction. This has access to a
+// chrome Profile.
+class ChromeSyncExtensionFunction : public ChromeUIThreadExtensionFunction {
public:
ChromeSyncExtensionFunction();
- virtual bool RunImpl() OVERRIDE;
+ protected:
+ virtual ~ChromeSyncExtensionFunction();
+ // Deprecated, see SyncExtensionFunction::RunSync.
virtual bool RunSync() = 0;
- protected:
- virtual ~ChromeSyncExtensionFunction();
+ private:
+ virtual ResponseAction Run() OVERRIDE;
};
#endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
« no previous file with comments | « chrome/browser/extensions/api/webview/webview_api.cc ('k') | chrome/browser/extensions/chrome_extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698