Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 85e051c1681b2e666541a80e873c7739112af634..86523364d12b05943652d0dc5785a03758f2e3f4 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -215,7 +215,7 @@ WebstorePrivateApi::PopApprovalForTesting(
WebstorePrivateInstallBundleFunction::WebstorePrivateInstallBundleFunction() {}
WebstorePrivateInstallBundleFunction::~WebstorePrivateInstallBundleFunction() {}
-bool WebstorePrivateInstallBundleFunction::RunImpl() {
+bool WebstorePrivateInstallBundleFunction::RunAsync() {
scoped_ptr<InstallBundle::Params> params(
InstallBundle::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
@@ -261,13 +261,13 @@ void WebstorePrivateInstallBundleFunction::OnBundleInstallCanceled(
SendResponse(false);
- Release(); // Balanced in RunImpl().
+ Release(); // Balanced in RunAsync().
}
void WebstorePrivateInstallBundleFunction::OnBundleInstallCompleted() {
SendResponse(true);
- Release(); // Balanced in RunImpl().
+ Release(); // Balanced in RunAsync().
}
WebstorePrivateBeginInstallWithManifest3Function::
@@ -276,7 +276,7 @@ WebstorePrivateBeginInstallWithManifest3Function::
WebstorePrivateBeginInstallWithManifest3Function::
~WebstorePrivateBeginInstallWithManifest3Function() {}
-bool WebstorePrivateBeginInstallWithManifest3Function::RunImpl() {
+bool WebstorePrivateBeginInstallWithManifest3Function::RunAsync() {
params_ = BeginInstallWithManifest3::Params::Create(*args_);
EXTENSION_FUNCTION_VALIDATE(params_);
@@ -434,7 +434,7 @@ void WebstorePrivateBeginInstallWithManifest3Function::OnWebstoreParseFailure(
g_pending_installs.Get().EraseInstall(GetProfile(), id);
SendResponse(false);
- // Matches the AddRef in RunImpl().
+ // Matches the AddRef in RunAsync().
Release();
}
@@ -447,7 +447,7 @@ void WebstorePrivateBeginInstallWithManifest3Function::SigninFailed(
g_pending_installs.Get().EraseInstall(GetProfile(), params_->details.id);
SendResponse(false);
- // Matches the AddRef in RunImpl().
+ // Matches the AddRef in RunAsync().
Release();
}
@@ -503,7 +503,7 @@ void WebstorePrivateBeginInstallWithManifest3Function::InstallUIProceed() {
ExtensionService::RecordPermissionMessagesHistogram(
dummy_extension_.get(), "Extensions.Permissions_WebStoreInstall");
- // Matches the AddRef in RunImpl().
+ // Matches the AddRef in RunAsync().
Release();
}
@@ -529,7 +529,7 @@ void WebstorePrivateBeginInstallWithManifest3Function::InstallUIAbort(
ExtensionService::RecordPermissionMessagesHistogram(dummy_extension_.get(),
histogram_name.c_str());
- // Matches the AddRef in RunImpl().
+ // Matches the AddRef in RunAsync().
Release();
}
@@ -539,7 +539,7 @@ WebstorePrivateCompleteInstallFunction::
WebstorePrivateCompleteInstallFunction::
~WebstorePrivateCompleteInstallFunction() {}
-bool WebstorePrivateCompleteInstallFunction::RunImpl() {
+bool WebstorePrivateCompleteInstallFunction::RunAsync() {
scoped_ptr<CompleteInstall::Params> params(
CompleteInstall::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
@@ -601,7 +601,7 @@ void WebstorePrivateCompleteInstallFunction::OnExtensionInstallSuccess(
RecordWebstoreExtensionInstallResult(true);
- // Matches the AddRef in RunImpl().
+ // Matches the AddRef in RunAsync().
Release();
}
@@ -621,7 +621,7 @@ void WebstorePrivateCompleteInstallFunction::OnExtensionInstallFailure(
RecordWebstoreExtensionInstallResult(false);
- // Matches the AddRef in RunImpl().
+ // Matches the AddRef in RunAsync().
Release();
}
@@ -673,7 +673,7 @@ void WebstorePrivateGetWebGLStatusFunction::CreateResult(bool webgl_allowed) {
ParseWebgl_status(webgl_allowed ? "webgl_allowed" : "webgl_blocked"));
}
-bool WebstorePrivateGetWebGLStatusFunction::RunImpl() {
+bool WebstorePrivateGetWebGLStatusFunction::RunAsync() {
feature_checker_->CheckGPUFeatureAvailability();
return true;
}
@@ -699,7 +699,7 @@ WebstorePrivateSignInFunction::WebstorePrivateSignInFunction()
: signin_manager_(NULL) {}
WebstorePrivateSignInFunction::~WebstorePrivateSignInFunction() {}
-bool WebstorePrivateSignInFunction::RunImpl() {
+bool WebstorePrivateSignInFunction::RunAsync() {
scoped_ptr<SignIn::Params> params = SignIn::Params::Create(*args_);
EXTENSION_FUNCTION_VALIDATE(params);
@@ -772,7 +772,7 @@ void WebstorePrivateSignInFunction::SigninFailed(
SendResponse(false);
SigninManagerFactory::GetInstance()->RemoveObserver(this);
- Release(); // Balanced in RunImpl().
+ Release(); // Balanced in RunAsync().
}
void WebstorePrivateSignInFunction::SigninSuccess() {
@@ -789,7 +789,7 @@ void WebstorePrivateSignInFunction::MergeSessionComplete(
}
SigninManagerFactory::GetInstance()->RemoveObserver(this);
- Release(); // Balanced in RunImpl().
+ Release(); // Balanced in RunAsync().
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698