chrome/browser/extensions/api/sessions/sessions_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/sessions/sessions_api.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc

index 1b7fc2d60d0e66bd22ebcf71513d7b113b350b28..f0f8ddb7555bfe11a5b83500f8b23e71add07e43 100644

--- a/chrome/browser/extensions/api/sessions/sessions_api.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc

@@ -342,7 +342,7 @@ SessionsGetDevicesFunction::CreateSessionModel(

scoped_ptr<api::sessions::Device> SessionsGetDevicesFunction::CreateDeviceModel(

const browser_sync::SyncedSession* session) {

int max_results = api::sessions::MAX_SESSION_RESULTS;

- // Already validated in RunImpl().

+ // Already validated in RunAsync().

scoped_ptr<GetDevices::Params> params(GetDevices::Params::Create(*args_));

if (params->filter && params->filter->max_results)

max_results = *params->filter->max_results;