Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: chrome/browser/extensions/api/processes/processes_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/processes/processes_api.cc
diff --git a/chrome/browser/extensions/api/processes/processes_api.cc b/chrome/browser/extensions/api/processes/processes_api.cc
index 70bc204131a1ec52cb9b359621b217d6be9e34a9..d09cc5efb8bce4435c79d059bcd158b8233d0779 100644
--- a/chrome/browser/extensions/api/processes/processes_api.cc
+++ b/chrome/browser/extensions/api/processes/processes_api.cc
@@ -538,7 +538,7 @@ void ProcessesAPI::OnListenerRemoved(const EventListenerInfo& details) {
GetProcessIdForTabFunction::GetProcessIdForTabFunction() : tab_id_(-1) {
}
-bool GetProcessIdForTabFunction::RunImpl() {
+bool GetProcessIdForTabFunction::RunAsync() {
#if defined(ENABLE_TASK_MANAGER)
EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &tab_id_));
@@ -592,14 +592,14 @@ void GetProcessIdForTabFunction::GetProcessIdForTab() {
SendResponse(true);
}
- // Balance the AddRef in the RunImpl.
+ // Balance the AddRef in the RunAsync.
Release();
}
TerminateFunction::TerminateFunction() : process_id_(-1) {
}
-bool TerminateFunction::RunImpl() {
+bool TerminateFunction::RunAsync() {
#if defined(ENABLE_TASK_MANAGER)
EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &process_id_));
@@ -662,7 +662,7 @@ void TerminateFunction::TerminateProcess() {
SendResponse(true);
}
- // Balance the AddRef in the RunImpl.
+ // Balance the AddRef in the RunAsync.
Release();
#else
error_ = errors::kExtensionNotSupported;
@@ -680,7 +680,7 @@ GetProcessInfoFunction::GetProcessInfoFunction()
GetProcessInfoFunction::~GetProcessInfoFunction() {
}
-bool GetProcessInfoFunction::RunImpl() {
+bool GetProcessInfoFunction::RunAsync() {
#if defined(ENABLE_TASK_MANAGER)
base::Value* processes = NULL;
@@ -763,7 +763,7 @@ void GetProcessInfoFunction::GatherProcessInfo() {
SetResult(processes);
SendResponse(true);
- // Balance the AddRef in the RunImpl.
+ // Balance the AddRef in the RunAsync.
Release();
#endif // defined(ENABLE_TASK_MANAGER)
}

Powered by Google App Engine
This is Rietveld 408576698