Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5442)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api.cc
diff --git a/chrome/browser/extensions/api/permissions/permissions_api.cc b/chrome/browser/extensions/api/permissions/permissions_api.cc
index 162135e78f6a9a2726b8ca7beee08c47e6e2eb34..76f875da602e33dd4d525bf9245ece6e399ce32e 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api.cc
+++ b/chrome/browser/extensions/api/permissions/permissions_api.cc
@@ -131,18 +131,18 @@ void PermissionsRequestFunction::InstallUIProceed() {
results_ = Request::Results::Create(true);
SendResponse(true);
- Release(); // Balanced in RunImpl().
+ Release(); // Balanced in RunAsync().
}
void PermissionsRequestFunction::InstallUIAbort(bool user_initiated) {
SendResponse(true);
- Release(); // Balanced in RunImpl().
+ Release(); // Balanced in RunAsync().
}
PermissionsRequestFunction::~PermissionsRequestFunction() {}
-bool PermissionsRequestFunction::RunImpl() {
+bool PermissionsRequestFunction::RunAsync() {
results_ = Request::Results::Create(false);
if (!user_gesture() &&

Powered by Google App Engine
This is Rietveld 408576698