chrome/browser/extensions/api/notifications/notifications_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/notifications/notifications_api.h

diff --git a/chrome/browser/extensions/api/notifications/notifications_api.h b/chrome/browser/extensions/api/notifications/notifications_api.h

index 02fee4bfb5489e3acfe791524a993b2dc75c3fb7..bd1b511c6012ccacc094b9bc60fca9eefbe4016f 100644

--- a/chrome/browser/extensions/api/notifications/notifications_api.h

+++ b/chrome/browser/extensions/api/notifications/notifications_api.h

@@ -41,11 +41,11 @@ class NotificationsApiFunction : public ChromeAsyncExtensionFunction {

// notifications for a notifier have been disabled.

virtual bool CanRunWhileDisabled() const;

- // Called inside of RunImpl.

+ // Called inside of RunAsync.

virtual bool RunNotificationsApi() = 0;

// UITHreadExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

message_center::NotificationType MapApiTemplateTypeToType(

api::notifications::TemplateType type);