chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h ('k') | chrome/browser/extensions/api/input_ime/input_ime_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

index e89d460dea9ad0370d8cbce8f91086395e27ac39..54453c537f022c993178a2b7fd674da99ac72560 100644

--- a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

@@ -21,7 +21,7 @@ ImageWriterPrivateWriteFromUrlFunction::

~ImageWriterPrivateWriteFromUrlFunction() {

}

-bool ImageWriterPrivateWriteFromUrlFunction::RunImpl() {

+bool ImageWriterPrivateWriteFromUrlFunction::RunAsync() {

scoped_ptr<image_writer_api::WriteFromUrl::Params> params(

image_writer_api::WriteFromUrl::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

@@ -65,7 +65,7 @@ ImageWriterPrivateWriteFromFileFunction::

~ImageWriterPrivateWriteFromFileFunction() {

}

-bool ImageWriterPrivateWriteFromFileFunction::RunImpl() {

+bool ImageWriterPrivateWriteFromFileFunction::RunAsync() {

std::string filesystem_name;

std::string filesystem_path;

std::string storage_unit_id;

@@ -109,7 +109,7 @@ ImageWriterPrivateCancelWriteFunction::

~ImageWriterPrivateCancelWriteFunction() {

}

-bool ImageWriterPrivateCancelWriteFunction::RunImpl() {

+bool ImageWriterPrivateCancelWriteFunction::RunAsync() {

image_writer::OperationManager::Get(GetProfile())->CancelWrite(

extension_id(),

base::Bind(&ImageWriterPrivateCancelWriteFunction::OnWriteCancelled,

@@ -134,7 +134,7 @@ ImageWriterPrivateDestroyPartitionsFunction::

~ImageWriterPrivateDestroyPartitionsFunction() {

}

-bool ImageWriterPrivateDestroyPartitionsFunction::RunImpl() {

+bool ImageWriterPrivateDestroyPartitionsFunction::RunAsync() {

scoped_ptr<image_writer_api::DestroyPartitions::Params> params(

image_writer_api::DestroyPartitions::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

@@ -166,7 +166,7 @@ ImageWriterPrivateListRemovableStorageDevicesFunction::

~ImageWriterPrivateListRemovableStorageDevicesFunction() {

}

-bool ImageWriterPrivateListRemovableStorageDevicesFunction::RunImpl() {

+bool ImageWriterPrivateListRemovableStorageDevicesFunction::RunAsync() {

RemovableStorageProvider::GetAllDevices(

base::Bind(

&ImageWriterPrivateListRemovableStorageDevicesFunction::OnDeviceListReady,