Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/identity_apitest.cc
diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc
index 3b18d52d6f9b5d582aa41bfa3005f83b7d1a67da..48a392ac6e008bacedd3b032132a18ed9ed61198 100644
--- a/chrome/browser/extensions/api/identity/identity_apitest.cc
+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc
@@ -48,7 +48,7 @@ namespace utils = extension_function_test_utils;
static const char kAccessToken[] = "auth_token";
static const char kExtensionId[] = "ext_id";
-// This helps us be able to wait until an AsyncExtensionFunction calls
+// This helps us be able to wait until an UIThreadExtensionFunction calls
// SendResponse.
class SendResponseDelegate
: public UIThreadExtensionFunction::DelegateForTests {
@@ -109,7 +109,7 @@ class AsyncExtensionBrowserTest : public ExtensionBrowserTest {
function->set_browser_context(browser()->profile());
function->set_has_callback(true);
- function->Run();
+ function->Run()->Execute();
}
std::string WaitForError(UIThreadExtensionFunction* function) {
@@ -132,7 +132,7 @@ class AsyncExtensionBrowserTest : public ExtensionBrowserTest {
private:
void RunMessageLoopUntilResponse() {
- // If the RunImpl of |function| didn't already call SendResponse, run the
+ // If the RunAsync of |function| didn't already call SendResponse, run the
// message loop until they do.
if (!response_delegate_->HasResponse()) {
response_delegate_->set_should_post_quit(true);
« no previous file with comments | « chrome/browser/extensions/api/identity/identity_api.cc ('k') | chrome/browser/extensions/api/idle/idle_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698