chrome/browser/extensions/api/extension_action/extension_action_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/execute_code_function.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.h

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.h b/chrome/browser/extensions/api/extension_action/extension_action_api.h

index c000da56bb0b5b77d274321209b7ea5e86481e93..dfd0e6e0026c81f8b67c61e384c05af08a0ea0c1 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.h

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.h

@@ -363,7 +363,7 @@ class BrowserActionOpenPopupFunction : public ChromeAsyncExtensionFunction,

virtual ~BrowserActionOpenPopupFunction() {}

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

virtual void Observe(int type,

const content::NotificationSource& source,