Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.h
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h
index 41ce8e437004bebf79947f62c9e60580bbd37327..d678edade9bb0db3b5e56662150c3213212fddaf 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h
@@ -162,7 +162,7 @@ class DeveloperPrivateGetItemsInfoFunction
virtual ~DeveloperPrivateGetItemsInfoFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
private:
scoped_ptr<developer::ItemInfo> CreateItemInfo(const Extension& item,
@@ -291,7 +291,7 @@ class DeveloperPrivateChooseEntryFunction : public ChromeAsyncExtensionFunction,
public EntryPickerClient {
protected:
virtual ~DeveloperPrivateChooseEntryFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
bool ShowPicker(ui::SelectFileDialog::Type picker_type,
const base::FilePath& last_directory,
const base::string16& select_title,
@@ -312,7 +312,7 @@ class DeveloperPrivateLoadUnpackedFunction
protected:
virtual ~DeveloperPrivateLoadUnpackedFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
// EntryPickerCLient implementation.
virtual void FileSelected(const base::FilePath& path) OVERRIDE;
@@ -327,7 +327,7 @@ class DeveloperPrivateChoosePathFunction
protected:
virtual ~DeveloperPrivateChoosePathFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
// EntryPickerClient functions.
virtual void FileSelected(const base::FilePath& path) OVERRIDE;
@@ -352,7 +352,7 @@ class DeveloperPrivatePackDirectoryFunction
protected:
virtual ~DeveloperPrivatePackDirectoryFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
private:
scoped_refptr<PackExtensionJob> pack_job_;
@@ -385,7 +385,7 @@ class DeveloperPrivateLoadDirectoryFunction
virtual ~DeveloperPrivateLoadDirectoryFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
void ClearExistingDirectoryContent(const base::FilePath& project_path);
@@ -442,7 +442,7 @@ class DeveloperPrivateRequestFileSourceFunction
virtual ~DeveloperPrivateRequestFileSourceFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
private:
void LaunchCallback(const base::DictionaryValue& results);
@@ -460,7 +460,7 @@ class DeveloperPrivateOpenDevToolsFunction
virtual ~DeveloperPrivateOpenDevToolsFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
};
} // namespace api

Powered by Google App Engine
This is Rietveld 408576698