chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h ('k') | chrome/browser/extensions/api/alarms/alarms_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

index bb99213470b6272e1ffa5d4ebddc146ffa50a34d..ba4f4a925be61ca5e7c79899b5f4cb2934e00f01 100644

--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

@@ -95,7 +95,7 @@ void ActivityLogAPI::OnExtensionActivity(scoped_refptr<Action> activity) {

EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass());

}

-bool ActivityLogPrivateGetExtensionActivitiesFunction::RunImpl() {

+bool ActivityLogPrivateGetExtensionActivitiesFunction::RunAsync() {

scoped_ptr<activity_log_private::GetExtensionActivities::Params> params(

activity_log_private::GetExtensionActivities::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

@@ -176,7 +176,7 @@ void ActivityLogPrivateGetExtensionActivitiesFunction::OnLookupCompleted(

SendResponse(true);

}

-bool ActivityLogPrivateDeleteActivitiesFunction::RunImpl() {

+bool ActivityLogPrivateDeleteActivitiesFunction::RunAsync() {

scoped_ptr<activity_log_private::DeleteActivities::Params> params(

activity_log_private::DeleteActivities::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

@@ -195,14 +195,14 @@ bool ActivityLogPrivateDeleteActivitiesFunction::RunImpl() {

return true;

}

-bool ActivityLogPrivateDeleteDatabaseFunction::RunImpl() {

+bool ActivityLogPrivateDeleteDatabaseFunction::RunAsync() {

ActivityLog* activity_log = ActivityLog::GetInstance(GetProfile());

DCHECK(activity_log);

activity_log->DeleteDatabase();

return true;

}

-bool ActivityLogPrivateDeleteUrlsFunction::RunImpl() {

+bool ActivityLogPrivateDeleteUrlsFunction::RunAsync() {

scoped_ptr<activity_log_private::DeleteUrls::Params> params(

activity_log_private::DeleteUrls::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());