chrome/browser/extensions/api/feedback_private/feedback_private_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: appshell Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h ('K') | « chrome/browser/extensions/api/feedback_private/feedback_private_api.h ('k') | chrome/browser/extensions/api/file_system/file_system_api.h » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

index 4a7eaae2a28c81939b845812487d52eafce1833f..cc05fcaee16bb6f5e33bb1c1525ad4c2db8c3dab 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

@@ -142,7 +142,7 @@ bool FeedbackPrivateGetUserEmailFunction::RunSync() {

return true;

}

-bool FeedbackPrivateGetSystemInformationFunction::RunImpl() {

+bool FeedbackPrivateGetSystemInformationFunction::RunAsync() {

// TODO(rkc): Remove logging once crbug.com/284662 is closed.

LOG(WARNING) << "FEEDBACK_DEBUG: System information requested.";

FeedbackService* service =

@@ -161,7 +161,7 @@ void FeedbackPrivateGetSystemInformationFunction::OnCompleted(

SendResponse(true);

}

-bool FeedbackPrivateSendFeedbackFunction::RunImpl() {

+bool FeedbackPrivateSendFeedbackFunction::RunAsync() {

scoped_ptr<feedback_private::SendFeedback::Params> params(

feedback_private::SendFeedback::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());