chrome/browser/extensions/api/execute_code_function.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/execute_code_function.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: appshell Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/execute_code_function.cc

diff --git a/chrome/browser/extensions/api/execute_code_function.cc b/chrome/browser/extensions/api/execute_code_function.cc

index fd19219959027298698709d70070078ebb432c6e..f06c91c66fd853c6980127335a228732980a619f 100644

--- a/chrome/browser/extensions/api/execute_code_function.cc

+++ b/chrome/browser/extensions/api/execute_code_function.cc

@@ -162,7 +162,7 @@ bool ExecuteCodeFunction::HasPermission() {

return true;

}

-bool ExecuteCodeFunction::RunImpl() {

+bool ExecuteCodeFunction::RunAsync() {

EXTENSION_FUNCTION_VALIDATE(Init());

if (!details_->code.get() && !details_->file.get()) {