apps/shell/browser/shell_app_window_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/shell/browser/shell_app_window_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: appshell Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: apps/shell/browser/shell_app_window_api.cc

diff --git a/apps/shell/browser/shell_app_window_api.cc b/apps/shell/browser/shell_app_window_api.cc

index 136a0ce87703beca5a2afb847fe4dde8f141f36b..8526f4529c6b800d36fc68994a15e22fa8d4723e 100644

--- a/apps/shell/browser/shell_app_window_api.cc

+++ b/apps/shell/browser/shell_app_window_api.cc

@@ -51,7 +51,7 @@ ShellAppWindowCreateFunction::ShellAppWindowCreateFunction() {}

ShellAppWindowCreateFunction::~ShellAppWindowCreateFunction() {}

-bool ShellAppWindowCreateFunction::RunImpl() {

+bool ShellAppWindowCreateFunction::RunAsync() {

// Arguments must contain a URL and may contain options and a callback.

if (args_->GetSize() < 1 || args_->GetSize() > 3)

return false;