Drive extension functions from ExtensionFunction::Run. The

extensions/browser/extension_function_dispatcher.cc

Index: extensions/browser/extension_function_dispatcher.cc
diff --git a/extensions/browser/extension_function_dispatcher.cc b/extensions/browser/extension_function_dispatcher.cc
index dd5f30a8f436c11ca87165b68fa10a1f0887acb9..fb3b50d66b28fedf401c357d85df84a44ec02079 100644
--- a/extensions/browser/extension_function_dispatcher.cc
+++ b/extensions/browser/extension_function_dispatcher.cc
@@ -274,7 +274,7 @@ void ExtensionFunctionDispatcher::DispatchOnIOThread(
                             static_cast<content::BrowserContext*>(profile_id));
     UMA_HISTOGRAM_SPARSE_SLOWLY("Extensions.FunctionCalls",
                                 function->histogram_value());
-    function->Run();
+    function->Run()->Execute();

[not at google - send to devlin, 2014/04/30 15:25:46]

I also find this a bit weird. At least Run() can have WARN_UNUSED_RESULT, and
there are a very small number of call sites, but still... weird.

It's also weird that "Run" and "Execute" are synonyms yet sort-of mean different
things here. Maybe "Execute" should be renamed "Respond" or "Reply" or "Send"?

I decided this was better than making those RespondNow() functions immediately
do their action, since they could declare those "ResponseAction" variables
locally and expect them not to do anything. This could be made to work by
changing Run() to return void again, and get rid of ResponseAction. An option I
didn't immediately consider since I like the "return" aspect, the point was
enforcing at the type level that only a single thing can happen.

Another option would be to define a
RunAndExecute()/RunAndRespond()/RunAndReply()/RunAndSend() function on
ExtensionFunction(), define Run() as protected, then the only option here would
be to call that.

[Ken Rockot(use gerrit already), 2014/04/30 23:38:08]

Of all the suggested verbs, I like "Send" the best, but I'd still like to think
about this some more now that you bring it up...

[not at google - send to devlin, 2014/04/30 23:54:39]

No rush :)

   } else {
     function->OnQuotaExceeded(violation_error);
   }
@@ -382,7 +382,7 @@ void ExtensionFunctionDispatcher::DispatchWithCallbackInternal(
         extension->id(), params.name, args.Pass(), browser_context_);
     UMA_HISTOGRAM_SPARSE_SLOWLY("Extensions.FunctionCalls",
                                 function->histogram_value());
-    function->Run();
+    function->Run()->Execute();
   } else {
     function->OnQuotaExceeded(violation_error);
   }