extensions/browser/api/dns/dns_api.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/dns/dns_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/dns/dns_api.cc

diff --git a/extensions/browser/api/dns/dns_api.cc b/extensions/browser/api/dns/dns_api.cc

index a3a7eb1498d08586f1eb2ebf024bc646f890768e..ef270c762e11875d45ffc5974d5f85c41bec5b3c 100644

--- a/extensions/browser/api/dns/dns_api.cc

+++ b/extensions/browser/api/dns/dns_api.cc

@@ -30,7 +30,7 @@ DnsResolveFunction::DnsResolveFunction()

DnsResolveFunction::~DnsResolveFunction() {}

-bool DnsResolveFunction::RunImpl() {

+bool DnsResolveFunction::RunAsync() {

scoped_ptr<Resolve::Params> params(Resolve::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());